I have no idea what this functionality does, what I do know is that the text can be better, I have rewritten it so it only uses the label.

Only local images are allowed.

Files: 
CommentFileSizeAuthor
#27 drupal-1837998-27.patch1.66 KBDavid Hernández
PASSED: [[SimpleTest]]: [MySQL] 59,431 pass(es).
[ View ]
#20 drupal-1837998-20.patch1.46 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 49,339 pass(es).
[ View ]
#20 interdiff.txt812 bytesdawehner
#13 vdc-1837998-13.patch1.55 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 48,980 pass(es).
[ View ]
#13 embed_display.png13.69 KBxjm
#1 drupal.core_.settingsscreentext.1837998.patch697 bytesBojhan
PASSED: [[SimpleTest]]: [MySQL] 47,997 pass(es).
[ View ]
before-views-embed-display.png40.67 KBBojhan

Comments

Status:Active» Needs review
StatusFileSize
new697 bytes
PASSED: [[SimpleTest]]: [MySQL] 47,997 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Usability, -VDC

The last submitted patch, drupal.core_.settingsscreentext.1837998.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Usability, +VDC

Well ... in fact you can use the embed display without this checkbox (it's just not visible in the UI), but yeah, for the normal user
don't have to know / don't want to know.

Status:Needs review» Reviewed & tested by the community

So i think the new text is okay even it's not really the truth.

Status:Reviewed & tested by the community» Needs review

I don't understand the new text either. Also, "allow using" is awkward.

What about keeping the #title from now and skip the description?

I think what we need is something like:

Allow embed displays to be added to Views through the user interface.

I am trying to understand why this is a setting at all, and what it's for. Drupal\views\Plugin\views\display\Embed is, like, empty.

Essentially, there is nothing that tells the user what an "embed display" is. Or me.

I don't get this setting either, honestly - I just figured it sounded weird.

I am trying to understand why this is a setting at all, and what it's for. Drupal\views\Plugin\views\display\Embed is, like, empty.

There are reasons we try to hide this from the user :)

It's doing nothing specia! You have a separated display which you can embed using php. All other display plugin types does someone additional, which you don't want in pure php code.

Maybe:

[ ] Configure embeddable displays in the user interface.
Embeddable displays are code-only displays that do not display on your site by default, but can be used by another module.

That's an awful lot of text, but we need to explain what it is somehow. A big problem here is that the views term "display" is exactly what it isn't semantically in this case. ;)

StatusFileSize
new13.69 KB
new1.55 KB
PASSED: [[SimpleTest]]: [MySQL] 48,980 pass(es).
[ View ]

Let's try this. I removed some of the other mostly-redundant descriptions so there's less text to read in this section, but included a description for this option.
embed_display.png

Status:Needs review» Reviewed & tested by the community

You seem to know that you shouldn't put "." at the end of the sentence. At least for me this new texts would help.

Title:Show the embed display in the ui. Show the embed display in the UI

Speaking of which.

Let's see what Bojhan thinks.

Assigned:Unassigned» Bojhan

Status:Reviewed & tested by the community» Needs work

We cleaned it up a lot, thanks xjm! However this could probably be a bit better, since its not common to have a checkbox that says "Configure X in the UI" and it could probably be shorter. What about:

"Allow embedded displays"
Embedded displays are code-only displays, often used by modules to do X.

I guess, you don't actually allow it? But we should probally say something along the lines of a "Show" or "Allow" - having it be "Configure X in the UI" is a bit confusing, because its so uncommon.

Assigned:Bojhan» Unassigned

Status:Needs work» Needs review
StatusFileSize
new812 bytes
new1.46 KB
PASSED: [[SimpleTest]]: [MySQL] 49,339 pass(es).
[ View ]

What about showing the user how to actually use embed displays?

Hmm, I'm not sure that's a good idea. The audience of UI helper text is not developers.

Well, the point is that the embed display is only useful when using views_embed_view() anyway...
I like it.

Status:Needs review» Needs work

I think the helper text can be for developers too, why not?! Developers do use Drupal too, sometimes... :) What if you have more of a 'dabbling' developer... this would be a good guide I think.

I'm also not sure why we are removing all the description text, this makes the options sound more vague than before. Which I would say is less helpful. For example, "Always show the master (default) display" is not that indicative of what it does. We lose the where and the why.

@damiankloip Agreed, lets work on it some more. Its natural though, sometimes we cut too much and often not enough :)

Opened #1882114: Remove listing filters option from views settings earlier, this removes another option, which I guess helps :)

Issue tags:+Novice, +Needs reroll

Status:Needs work» Needs review
Issue tags:-Needs reroll
StatusFileSize
new1.66 KB
PASSED: [[SimpleTest]]: [MySQL] 59,431 pass(es).
[ View ]

Re-rolled

Status:Needs review» Reviewed & tested by the community
Issue tags:-Usability, -VDC

Nice!

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.