Timeago display displays HTML on comments [#1838928]

This may be an issue to the timeago module, but im not sure.

Use timeago for comment creation/changed dates enabled on admin/config/user-interface/timeago, default install, adding a comment to the event shows up like this:

<time datetime="2012-11-13T00:09:04Z" pubdate="pubdate"><span class="date-time permalink"><a href="/comment/1#comment-1" rel="bookmark">&lt;span class="timeago" title="2012-11-13T00:09:04+00:00"&gt;Tue, 11/13/2012 - 00:09&lt;/span&gt;</a></span></time>

The inner span will be shown as link, since the anchor is around it. Disabling the setting turns it into this:

<time datetime="2012-11-13T00:09:04Z" pubdate="pubdate"><span class="date-time permalink"><a href="/comment/1#comment-1" rel="bookmark">Tue, 11/13/2012 - 00:09</a></span></time>

I havent found any preprocess in the theme, so I guess this is timeagos fault?

Comment	File	Size	Author
#13	commons-timeago-displays-html-1838928-13.patch	643 bytes	Devin Carlson
#4	commons-timeago-displays-html-1838928.patch	841 bytes	prashantgoel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ezra-g CreditAttribution: ezra-g commented 13 November 2012 at 16:47

Status:

Active

» Fixed

Thanks.

Ultimately this is a themeing issue, but having Timeago formatting on these links wasn't intentional, so I've disabled them:

http://drupalcode.org/project/commons_activity_streams.git/commit/51c0892

Comment #2

ezra-g CreditAttribution: ezra-g commented 18 November 2012 at 01:49

Component:	Code	» Theme
Status:	Fixed	» Active

Comment #3

ezra-g CreditAttribution: ezra-g commented 29 November 2012 at 00:02

Priority:

Normal

» Major

Comment #4

prashantgoel CreditAttribution: prashantgoel commented 14 December 2012 at 17:48

Status:

Active

» Needs review

File	Size
commons-timeago-displays-html-1838928.patch	841 bytes

Submitting the patch for resolving this issue.

Comment #5

Matt V. CreditAttribution: Matt V. commented 30 January 2013 at 06:45

Status:

Needs review

» Reviewed & tested by the community

The patch in #4 worked for me.

Comment #6

ezra-g CreditAttribution: ezra-g commented 30 January 2013 at 19:34

Status:

Reviewed & tested by the community

» Postponed (maintainer needs more info)

This is a patch to AdaptiveTheme's at_core project. Should it be a patch against Commons Origins?

Comment #7

WebSinPat CreditAttribution: WebSinPat commented 4 May 2013 at 15:36

Hello, I'm having the same issue in commons 7.x.3.2
I'm just wondering what is the correct fix i should apply..
Is the commit in #1 already supposed to be in code? Or should I apply the patch in #4? Or not apply the patch based on the comment in #6?

Well, i applied the patch in #4 and it fixed the issue of the html being printed to the screen.

However, I am still not getting a timeago type of date format. It still just has regular date and time.

Submitted by admin Sat, 05/04/2013 - 11:27

Is this a related issue, or should i file a new issue?

thanks.

Comment #8

Cellar Door CreditAttribution: Cellar Door commented 29 May 2013 at 16:05

If you take a look at #1996706: Timeago Patch Breaks functionality you'll see the js for timeago was removed in a patch recently. Putting those lines back into the module loads the helper js file and timeago works again.

Comment #9

Devin Carlson CreditAttribution: Devin Carlson commented 11 June 2013 at 21:33

Version:		» 7.x-3.2
Assigned:	Unassigned	» Devin Carlson
Status:	Postponed (maintainer needs more info)	» Needs review

This issue is caused by AdaptiveTheme wrapping comments in a link back to the comment itself.

Patch to AdaptiveTheme with workaround for Commons Origins incoming...

Comment #10

Devin Carlson CreditAttribution: Devin Carlson commented 12 June 2013 at 18:25

Version:

7.x-3.2

» 7.x-3.x-dev

Filed #2018081: Comment creation date links to same location as comment title against AdaptiveTheme.

Comment #11

stupiddingo CreditAttribution: stupiddingo commented 13 June 2013 at 17:56

Status:

Needs review

» Reviewed & tested by the community

Tested and marked #2018081: Comment creation date links to same location as comment title as RTBC. Same is true here I suppose?!

Comment #12

behoppe333 CreditAttribution: behoppe333 commented 20 June 2013 at 19:30

Newbie question: When I drush make a fresh instance of dev release, I won't see this patch until its status changes from RTBC to Fixed. Correct?

I ask because my fresh instance of dev release has this bug, I'm new to this community, and I'm making sure I understand how patches flow via commits to the code that I pull with git.

Thanks for any corrections or affirmations :-)