In some of the modules, we set default values in hook_node_prepare(), for some, in hook_form().

It would be cleaner to do it all in one place, and the form seems the most developer friendly place to do so.

CommentFileSizeAuthor
#2 pm-node-prepare.patch11.11 KBjuliangb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Project: Storm » Drupal PM (Project Management)
Component: Storm.module » Code
juliangb’s picture

juliangb CreditAttribution: juliangb commented
Assigned: Unassigned » juliangb
Issue summary: View changes
Status: Active » Needs review
FileSize
pm-node-prepare.patch11.11 KB

A really minor task, but got it done at last.

Expected result testing this is that all functions remain the same, it is just a small simplification in the code.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs review » Fixed

Committed and pushed to drupal.org.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 00c9653 on 7.x-1.x, 7.x-2.x by juliangb: 
    Issue #1843040 by juliangb: Cleanup: Move hook_node_prepare() into...