Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Subissue of #1787218: Convert testing variables to state system..
Change the variables menu_test_active_trail_initial, menu_test_hook_custom_theme_name, menu_test_menu_tree_set_path and menu_test_record_active_trail to the state system.
Comment | File | Size | Author |
---|---|---|---|
#10 | 1843954-menu_to_state-drupal8-10.patch | 6.94 KB | ACF |
#5 | 1843954-menu_to_state-drupal8-5.patch | 6.88 KB | ACF |
#1 | 1843954-menu_to_state-drupal8-1.patch | 6.88 KB | ACF |
Comments
Comment #1
ACF CreditAttribution: ACF commentedpatch attached.
Comment #2
aspilicious CreditAttribution: aspilicious commentedLets reroll and see if its still green
Comment #3
aspilicious CreditAttribution: aspilicious commented#1: 1843954-menu_to_state-drupal8-1.patch queued for re-testing.
Comment #5
ACF CreditAttribution: ACF commentedre-rolled
Comment #7
ACF CreditAttribution: ACF commented#5: 1843954-menu_to_state-drupal8-5.patch queued for re-testing.
Comment #8
gddI'd like to see all these get() calls set with their old default values if not present. It just makes the code read a lot easier and its more plain what will happen if a value is ever not present.
Other than that this looks good.
Comment #9
gddComment #10
ACF CreditAttribution: ACF commentedUpdated with get defaults.
Comment #11
aspilicious CreditAttribution: aspilicious commentedShould be fine now.
Comment #12
webchickCommitted and pushed to 8.x. Thanks!