This module connects your drupal site with your Bablic account.
Bablic is a service that provides full website localization with an easy integration, translation management system and integration with professional translators.

The module is simply adding the Bablic snippet to every page's HTML footer.

Homepage:
http://www.bablic.com

git
ishaijaffe@git.drupal.org:sandbox/ishaijaffe/1844010.git

Comments

parwan005’s picture

parwan005 CreditAttribution: parwan005 commented
Status: Needs review » Needs work

Hi,

please mention here project page path. Also proper git repo path from project page. Also do mention this is for which drupal version.

Thanks
Parwan

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented

Hi,
Firstly there is lots of issue regarding line spaces, indentation & comments.

Look at this !
http://ventral.org/pareview/httpgitdrupalorgsandboxishaijaffe1844010git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented

Manual Review :

1) Please don't add LICENSE.txt, it will be added by drupal community after completing review process and full project release.

2) Use L() function to make your links in line no 21 in bablic.module & line no: 16 in bablic.variable.inc

3) Please remove bablic_permission() as it does not contain any code.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)