Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If the user is using an adblocker to block the service, or if the ShareThis servers were to go down, then it should not interrupt other JS on the page. This is currently not the case - we get a 'stLight is undefined' error.
Patch forthcoming
Comment | File | Size | Author |
---|---|---|---|
#4 | sharethis-js_undefined-1845134-4.patch | 900 bytes | Jerenus |
#2 | sharethis_js_undefined_1845134_2.patch | 648 bytes | timfernihough |
#1 | sharethis_js_undefined_1845134_1.patch | 931 bytes | dalin |
Comments
Comment #1
dalinComment #2
timfernihough CreditAttribution: timfernihough commented@dalin,
I've downloaded and tested this and works well, marking RBTC.
In my case, I'm working with a responsive theme that relies heavily on Javascript to function and we are finding that the client this project is for has an audience with very high security settings in their browsers and in some cases it prevents ShareThis from loading. This cascades and causes the entire theme to break as a result because of the stLight error.
I had to modify it to work with the most recent stable version (7.x-2.5) as that is what we're using in our install profile, so I've uploaded a second patch here for anyone who may need it for their make file.
Comment #3
Jerenus CreditAttribution: Jerenus commentedComment #4
Jerenus CreditAttribution: Jerenus commentedJslint's suggestion.
Comment #5
Jerenus CreditAttribution: Jerenus commentedComment #6
RobLoachLooks good! I'll hopefully be able to commit today.
Comment #7
RobLoachThanks! https://drupal.org/commitlog/commit/5482/9fe4cdeb28f5471622a78aec81571ba...
Comment #8
Jerenus CreditAttribution: Jerenus commentedThank you for your encouragement. ;)