Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Raw print_r()
output is hard to read, wrapping it in <pre></pre>
improves readability a lot.
(Realized while trying to hunt down a suspected minor issue with Google fonts import.)
Patch coming.
Comment | File | Size | Author |
---|---|---|---|
#1 | fontyourface-Improve_readability_of_debugging_info-1845672-1.patch | 15.27 KB | Drave Robber |
Comments
Comment #1
Drave Robber CreditAttribution: Drave Robber commentedPatch attached.
Comment #2
sreynen CreditAttribution: sreynen commentedI think the
<pre></pre>
needs to be added in the parameter, not the message. fontyourface_log() passes the message to watchdog(), which passes it to t(). http://drupal.org/node/322774 says block tags shouldn't be in messages, and<pre></pre>
is a block tag.Comment #3
Drave Robber CreditAttribution: Drave Robber commented<blabla>While I believe 'block tags' might be a bit too formal criterion given how different use cases can be,</blabla>
this makes a lot of sense on entirely different grounds - not making existing translations obsolete if we can avoid that.
Now, putting
<pre>
in the parameter would also require changing the placeholder from@
to!
; as we're mostly dumping external data, we should probably take some precautions. Sowould become
(for some obscure reason, theme_dblog_message() does
filter_xss()
only on overview, not on details page)Thoughts?
Comment #4
Neslee Canil Pinto