Support from Acquia helps fund testing for Drupal Acquia logo

Comments

annikaC’s picture

I've adapted this to work with Features Extra latest dev too.

pfrenssen’s picture

Status: Active » Postponed

Nodequeue 3.x is at the moment in early development. It is not even mentioned on the project page yet, and the recommended version is still 2.x. I'm going to postpone this until 3.x gains traction.

The patch would break existing implementations too, it should work with both versions of Nodequeue.

pfrenssen’s picture

pfrenssen’s picture

Title: Make fe_nodequeue workt with nodequeue-7.x-3.x-dev » Make fe_nodequeue work with nodequeue-7.x-3.x-dev
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Status: Postponed » Active

There seems to be interest in this. I'm putting it back to active. We do need an update to the patch so that it is compatible with both Nodequeue 7.x-2.x and 7.x-3.x.

moonray’s picture

Probably the easiest is something like:

<?php
    if (function_exists('nodequeue_load_queue_by_name')) {
      $nodequeue_static = nodequeue_load_queue_by_name($name);
    }
    else {
      $nodequeue_static = nodequeue_load($name);
    }
?>

Better would be some sort of nodequeue API version check.

pfrenssen’s picture

Yeah indeed. It remains to be seen when this will become relevant. There is no mention of Nodequeue 3.x at all on their project page, and the development seems to have stalled (there have only been 4 commits in the past 12 months). It will probably be quite some time before Nodequeue 3.x is ready.

moonray’s picture

We're using nodequeue 3 due to some requirements that weren't in 2. There are probably others out there that use it as well.
It seems like a simple fix, so why wait to include a solution?

jasperknops’s picture

The backwards compatible approach of moonray in #5 seems like the beste solution to me.

pfrenssen’s picture

Patches are always welcome!

moonray’s picture

Status: Active » Needs review
FileSize
1.91 KB

Attached patch makes features_extra compatible with nodequeue 3.

Status: Needs review » Needs work

The last submitted patch, features_extra-nodequeue_3_integration-1845752-10.patch, failed testing.

pfrenssen’s picture

Related issue: #2050119: PDOException: Unknown column 'qid' in 'field list': SELECT qid, name FROM {nodequeue_queue} fe_nodequeue error.

It reports a PDO exception caused by changes to the database schema in Nodequeue 7.x-3.x.

pfrenssen’s picture

Component: Code » FE Nodequeue
dan.munn’s picture

Status: Needs work » Needs review
FileSize
2.27 KB

Have gone the route of the former patch, also included queue creation support under new nodequeue which looks for new attribute set.

Status: Needs review » Needs work

The last submitted patch, features_extra-nodequeue_3.x_dev_support-1845752-14.patch, failed testing.

dan.munn’s picture

Take 2 - have removed the subqueues attribute from the exported data within the test as this is now always unset as per the changes in patch.

dan.munn’s picture

Status: Needs work » Needs review
FileSize
2.7 KB

Sorry, in error forgot to flag status as needs review (not trying to spam the thread).

elvis2’s picture

#17 worked for me. I ran into this error when doing a "drush fd featurename" from the command line. Your patch got rid my issue.

Thanks!

Robin_K’s picture

#17 worked for me too, I was getting errors when trying to create a new feature with nodequeues, patch seemed to have fixed it.

santhony’s picture

Issue summary: View changes

deleted.

rolfmeijer’s picture

moonray’s picture

Status: Needs review » Reviewed & tested by the community

#17 works for me. This patch is really a long time coming.

pfrenssen’s picture

Status: Reviewed & tested by the community » Postponed

Postponing on having a stable release for Nodequeue 3.x.