Enable optional first pass of SmatyPants with "w" set in smartypants_attributes [#184667]

The TinyMCE editor automatically converts all double-quotes to ", If using the TinyMCE module for editing your content, which effectively disables SmartPants' smart quotes functionality. SmartPants has the ability to convert them back by including "w" in $smartypants_attributes. I've added a few lines of code to optionally enable a first run of SmartyPants. Maybe this should be in another area of the Typogrify configuration screen, though.


92a93,95
>     if( variable_get("typogrify_smartypants_attributes_w", 0) ) {
>       $text = SmartyPants($text, 'w');
>     }
232a236,253
>
>   // Advanced SmartyPants configuration
>   $form['typogrify_settings']['spadvanced'] = array(
>     '#type' => 'fieldset',
>     '#title' => t('Advanced SmartyPants'),
>     '#collapsible' => TRUE,
>     '#collapsed' => TRUE,
>   );
>
>
>   // SmartyPants Attribute - "w" - Convert &quot;
>   $form['typogrify_settings']['spadvanced']['typogrify_smartypants_attributes_w'] = array(
>     '#type' => 'checkbox',
>     '#title' => t('Translates any instance of &amp;quot;'),
>     '#default_value' => variable_get('typogrify_smartypants_attributes_w', 0),
>   );
>
>
258c279

Comment	File	Size	Author
#4	typogrify-convert-quots.patch	756 bytes	noelbush

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Tim Gambell CreditAttribution: Tim Gambell commented 17 November 2007 at 23:04

Hi Apostate,

Sounds like a plan. I'll get that into the module. Thanks for the suggestion!

Comment #2

Tim Gambell CreditAttribution: Tim Gambell commented 17 November 2007 at 23:51

Assigned:

Unassigned

» Tim Gambell

Comment #3

mikl CreditAttribution: mikl commented 13 January 2009 at 13:24

Assigned:

Tim Gambell

» mikl

Comment #4

noelbush CreditAttribution: noelbush commented 19 September 2009 at 20:52

File	Size
typogrify-convert-quots.patch	756 bytes

Did this ever make it in? To me it seemed like maybe it would just make sense to set the $convert_quot option for all the "do everything" values of the $attr switch, as in the attached patch (note that this is against the Drupal 6 version of this module). Any problem with that? It seems to me that this matches expected behavior when you enable the smartypants quote fixing.