In case you create the invoice via bulk operations etc. then generate_invoice_id() returns the same ID.

Because the sql query orders the invoices by "created" timestamp, which is then not anymore unique enough, therefore it is better to order by invoice id.

CommentFileSizeAuthor
#2 i1847326-2.patch632 bytesattiks
#1 commerce_invoice-1847326-1.patch584 bytestobiasb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Status: Active » Needs review
FileSize
commerce_invoice-1847326-1.patch584 bytes
attiks’s picture

attiks CreditAttribution: attiks commented
FileSize
i1847326-2.patch632 bytes

Patch looks good, I added a line to filter by type

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Closing all Drupal 7 issues as this project will only be supported for Drupal 8