After this got in #1553114: Adding files should be a multi-step process now there is no need to have the edit modal form

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

Status: Active » Needs review
FileSize
2.96 KB
arthurf’s picture

Tested this with new and existing media and seems to work correctly. Nice to see another file get removed!

Is the next logical issue to address the ctools modal for a file field edit?

ParisLiakos’s picture

Is the next logical issue to address the ctools modal for a file field edit?

what do you mean with address?

Dave Reid’s picture

I'm not sure what we can do with the 'Edit' button yet?

arthurf’s picture

I think it's strange that we have two different styles of interfaces for dealing with files- ctools modal and the media modal. It's beyond the scope of this issue so I'll hush up for now.

Dave Reid’s picture

Yeah I guess we could open an issue to use our custom modal with the Edit file button, but the hope was to reduce code we have to maintain. I think a better issue would be to style the ctools modal to "look" like our custom modal for now (as a separate issue).

ParisLiakos’s picture

Status: Needs review » Fixed

i went ahead and committed #1 since this is quite a usability improvement
http://drupalcode.org/project/media.git/commit/156399b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gmclelland’s picture

Did anyone open up a followup issue as per @Dave Reid's suggestions in #6 to style the ctools modal dialog to look like media module's modal dialog?