API page: http://api.drupal.org/api/drupal/core%21modules%21search%21search.pages....

The function initialize the $redirect variable, but that variable is never used from the function, nor is the variable defined as global variable.

Files: 
CommentFileSizeAuthor
#9 drupal-remove-variable-1848774-9.patch457 byteskiamlaluno
PASSED: [[SimpleTest]]: [MySQL] 39,658 pass(es).
[ View ]
#3 drupal-remove-variable-1848774-3.patch477 bytesIshaDakota
PASSED: [[SimpleTest]]: [MySQL] 50,487 pass(es).
[ View ]

Comments

I checked the code used from the function in other Drupal versions. $redirect was introduced in Drupal 7, but the code has never used that variable, except when initializing it.

Issue tags:+Novice

Tagging as novice

Status:Active» Needs review
StatusFileSize
new477 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,487 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, drupal-remove-variable-1848774-3.patch, failed testing.

Status:Needs work» Needs review

Issue tags:+Novice

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Fixed

Committed/pushued to 8.x, thanks!

Version:8.x-dev» 7.x-dev
Status:Fixed» Needs review
StatusFileSize
new457 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,658 pass(es).
[ View ]

This is the patch for Drupal 7. The same variable that appears in the Drupal 8 code appears in Drupal 7's search_view().

Status:Needs review» Reviewed & tested by the community

How do you always find that stuff? ;) Looks good.

@Bedir I am the founder of the "Give home to an orphan variable" association. ;-)

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.