Posted by xjm

From #1850352: config_import_invoke_owner() should check whether a module exists before invoking its hooks. module_hook() does not check module_exists(), just function_exists(), so in certain circumstances (like during test runs), something might attempt to invoke hooks for a disabled module. Should module_hook() be changed?

Files: 
CommentFileSizeAuthor
#1 module_exists-1850988-1.patch487 bytestim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new487 bytes
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..
[ View ]

I tried this while debugging that issue and it blew up.
I can't remember where though, let's find out

Status:Needs review» Needs work

The last submitted patch, module_exists-1850988-1.patch, failed testing.

Are there any plans to get this fixed in D7 as well? I couldn't find an issue for it. This bug hit with features, where components of disabled modules got imported (#1909522: Menu links of disabled feature modules are imported)

Issue summary:View changes

Removing myself from the author field so that I can unfollow the issue. --xjm