Follow block title is right (instead of left) of icons when horizontal layout is chosen [#1851302]

When using the Alignment: Horizontal setting on the follow links, you would expect the title to appear to the left of the icons. It currently displays to the right. (See attached screenshot.)

This is due to the <a> tag floating left but the <h2> title does not float.

span.follow-link-wrapper a {
float: left;
}

Comment	File	Size	Author
#2	follow-1810556-accessible-hiding-of-text-4.patch	5.21 KB	cwithout
#2	Follow links (text not hidden).png	42.64 KB	cwithout
#2	Follow links (text hidden).png	41.48 KB	cwithout
#2	Follow links (text hidden with nowrap).png	41.59 KB	cwithout
	Follow links (horizontal).png	42.64 KB	cwithout

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

cwithout CreditAttribution: cwithout commented 27 November 2012 at 00:55

So the easy way to fix this would be

span.follow-link-wrapper a {
  display: inline-block;
}

But unfortunately, inline-block doesn't work in IE7. It requires separate CSS or a hack like zoom:1; *display: inline;.

The other option is also float left the <h2> tag within the #block-follow-user and/or #block-follow-site divs. But that would require those ID's to be passed to follow-css.tpl.php so it could add float:left; to the appropriate div(s) only when the horizontal layout was chosen.

Comment #2

cwithout CreditAttribution: cwithout commented 1 May 2013 at 22:23

Status:

Active

» Needs review

File	Size
Follow links (text hidden with nowrap).png	41.59 KB
Follow links (text hidden).png	41.48 KB
Follow links (text not hidden).png	42.64 KB
follow-1810556-accessible-hiding-of-text-4.patch	5.21 KB

[Removed -- Posted to wrong issue. Do not use patch for this issue. IGNORE THESE ATTACHMENTS.]

Comment #3

cwithout CreditAttribution: cwithout commented 27 November 2012 at 01:11

Changing issue status.
Ignore patch and attachments in comment #2. Posted to wrong issue.

Comment #4

q0rban CreditAttribution: q0rban commented 30 April 2013 at 15:55

Status:

Active

» Closed (won't fix)

> you would expect the title to appear to the left of the icons

I disagree, I actually expect the icons to be to the left of the text. If you feel differently, you can fix this in your own CSS. Marking this as won't fix. :)

Comment #5

cwithout CreditAttribution: cwithout commented 1 May 2013 at 22:22

Status:

Closed (won't fix)

» Active

I think you're mistaken on what I mean by "title". I don't mean the text associated with the icons. I mean the title of the block.

In the original post, refer to the image with the large text that says "Follow D7 demo on:" with nothing after the colon. A normal person/user is not going to expect the associated content to show up to the left of a title, especially one that ends with a colon. They would expect the associated content to show up to the right of the colon.

http://drupal.org/files/Follow%20links%20(horizontal).png

Comment #6

cwithout CreditAttribution: cwithout commented 1 May 2013 at 22:27

Title:	Follow title is right (instead of left) of icons when horizontal layout is chosen	» Follow block title is right (instead of left) of icons when horizontal layout is chosen
Status:	Needs review	» Active

Updating issue title.