Reintroduce Views integration for contact.module

Some small cleanup.

Actually wrote a test and realized how much was actually broken, like it never actually appeared on some use-cases.

Tested this, works, code looks great, tests looks complete, comments look great.

Awesome!

Left the UUID in the test yml file.

Is this really the only way to check the access? It's an extra query for every row when you enable this. I realise contextual module does it as well but it's a horrible pattern. The only thing I can think of though is doing what contact module does in its own callback.

+ $path = "user/$uid/contact";
+ $menu_item = menu_get_item($path);
+ if (!$menu_item['access']) {
+ return;
+ }

We could rewrite _contact_personal_tab_access to accept multiple accounts, though I'm really wondering whether it's worth to do so,
as N function calls on N rows is nothing compared to all other things going on like entity API.

Would you be okay with directly calling the access method of contact? We didn't used that in D7 because people might want to replace the access logic and so could do this in one place via hook_menu_alter.

I think directly calling the access method is probably OK. It's not that much different to calling node_access() really.

If you think that's too fragile, just adding a comment explaining why we have to use menu_get_item() there might be enough as well.

To be honest, this is such an edge case that to require overriding the views handler is fine for me.

#10: drupal-1853526-10.patch queued for re-testing.

#10: drupal-1853526-10.patch queued for re-testing.

#10: drupal-1853526-10.patch queued for re-testing.

#10: drupal-1853526-10.patch queued for re-testing.

#10: drupal-1853526-10.patch queued for re-testing.

#10: drupal-1853526-10.patch queued for re-testing.

Moved some tiny bits around and fixed things here and there. The interdiff thought would be hard to read as files have been moved.

#22: drupal-1853526-22.patch queued for re-testing.

This should fix it.

Now!

+++ b/core/modules/contact/lib/Drupal/contact/Tests/Views/ContactLinkTest.php
@@ -0,0 +1,116 @@
+      $result = $this->xpath('//div[contains(@class, "views-field-contact")]//a[contains(@href, :uri)]', array(':uri' => $contact_uri));
+      $this->assertTrue(count($result));

AssertLink is not sufficient here?

Yeah we could use it here, though it feels always safer for me, to check the full output here, as this adds additional kind of test coverage.

Feel free to convince me of the opposite, then I'm happy to rerole.

#27: drupal-1853526-27.patch queued for re-testing.

+++ b/core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml
@@ -0,0 +1,119 @@
+human_name: test_contact_link

That should be label, I think.

Good catch, we def need to change this since the label patch landed :)

#34: 1853526-34.patch queued for re-testing.

Reroll. Unable to figure out Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: "The service definition "plugin.manager.views.access" does not exist." at D:\xampp\htdocs\d8\core\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\ContainerBuilder.php line 875

I shouted so many bad words while fixing those.

Great!

+++ b/core/modules/contact/lib/Drupal/contact/Plugin/views/field/ContactLink.phpundefined
@@ -0,0 +1,74 @@
+    if (!_contact_personal_tab_access($entity->getBCEntity())) {

Should be converted in #1938390: Convert contact_site_page and contact_person_page to a new-style Controller

Committed 1d3e064 and pushed to 8.x. Thanks!