From catch in #1805996: [META] Views in Drupal Core:

This isn't up-to-date with the core tracker schema which has some denormalization. Would be a critical performance regression if the tracker listing was updated to use it in its current state.

We were going to remove the view from the sandbox before the merge and re-add it (or at least I thought we were) but I discovered tonight when I tried to file a patch that it's still in there. So, we'll want to clean it up. We can probably do this when we convert the listing, but if not, the default view should be fixed or removed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

So the point catch is rising here is basically #1829734: Expose tracker data to views
I don't think there is a fundamental problem is using views for that, though it should perform.

xjm’s picture

Status: Active » Postponed

Cool, postponing this on that then.

xjm’s picture

Title: Views default tracker view needs work » Remove the old default tracker view
Status: Postponed » Needs review
FileSize
3.87 KB

Actually, changing my mind; we'll want to completely rebuild the view, and we can do that when we convert it to core. So let's remove old, critically non-performant default view.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, views-1853572-3.patch, failed testing.

catch’s picture

Status: Needs work » Needs review

#3: views-1853572-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views-1853572-3.patch, failed testing.

xjm’s picture

Status: Needs work » Needs review

#3: views-1853572-3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, views-1853572-3.patch, failed testing.

xjm’s picture

Status: Needs work » Needs review
FileSize
4.24 KB
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Lets remove it!

dawehner’s picture

I would personally first get the tracker conversion in, see #1829734: Expose tracker data to views and then conver this view to it.

So let's remove old, critically non-performant default view.

It seems to be, that people assume that a default view is actually used on the page. I really think this view is a good example of a non-trivial to configure view, so it should stay regardless whether it's usefull for an actual drupal site or not. Just for example you could use the some point when
dealing with the glossary view. Nearly noone really understands how to configure a glossary view out of the box, so having an example seems to be comparable with a good piece of documentation.

damiankloip’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Let's close this as a duplicate then and work in #1941830: Convert tracker listings to a view where we can create a new view. So the old one will get removed anyway.

alexpott’s picture

Issue summary: View changes
Status: Closed (duplicate) » Needs review
Issue tags: +Needs reroll
FileSize
15.93 KB

#2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall has exposed the fact that this is dependent on both the history and comment module to reliably manage this view we would need a new module.

The old patch does not apply.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

It is a bit sad, though this seems to cause more troubles than wanted.

xjm’s picture

+1 on committing this first and then restoring the functionality in #1941830: Convert tracker listings to a view when that lands (which can be whenever).

xjm’s picture

Issue tags: -Needs reroll

I don't think the patch @alexpott just created needed a reroll in the same comment where he created it? :) Though we might have some tests for this view kicking around. We'll know in a bit I guess.

damiankloip’s picture

Nope, there are tests for tracker plugins, but not for this actual view. So tests confirm, and I confirm, we can just yoink this out.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.