wysiwyg/wysiwyg.install:138: while ($format = db_fetch_object($result)) {
wysiwyg/wysiwyg.install:143: while ($filter = db_fetch_object($result2)) {
wysiwyg/wysiwyg.install:188: while ($profile = db_fetch_object($result)) {

http://drupal.org/update/modules/6/7#dbtng

Files: 

Comments

The code you're referencing is in wysiwyg_update_6001(), therefore it won't be executed in a D7 installation. I don't think there is anything to fix here.

Title:Please remove db_fetch_object in code. it is not in Drupal 7 apiRemove old update functions
Category:bug» task

That is true, that code would not run in D7.

So the solution could be to remove this code completely from 7.x

Issue summary:View changes
Status:Active» Needs review
StatusFileSize
new4.09 KB

Patch attached

Status:Needs review» Fixed

I made a few tests today and D7 does run the old updates if the module's schema number is 6xxx in the system table, implying we should have ported these functions to DBTNG as well.

However, since these functions also exist in the 6.x-2.x branch along with other update functions performing the same task as some of the 7xxx update function in the 7.x-2.x branch, and the recommendation is to upgrade to the latest minor release before upgrading to a major release; I think we should still remove them.

However, we must also implement hook_update_last_removed() to make users aware of this fact when upgrading.

I have done so, and committed this to 7.x-2.x.

Thanks for reporting and patching this!

Can't post a patch right now, but the commit is e4a4d9d

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.