Using library_load, integration files are currently loaded before the library itself is loaded. In all cases (CSS, JS and certainly PHP), I think you'd want your integration files to come later, since they will patch, extend, or otherwise leverage the library files themselves. This patch moves the integration file loading to after loading the actual library files.

#10 1855918-10-integration-files-order.patch1.08 KBpc-wurm
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1855918-10-integration-files-order.patch.
[ View ]


Status:Active» Needs review

Status:Needs review» Reviewed & tested by the community

Patch working, thanks !

Category:task» bug
Priority:Normal» Major

For PHP files, this is a pretty big bug report actually, as you can't use PHP functions or classes from the library you depend on... #fail

Will commit this soon. This is technically a BC-break, but, again, I totally see this as a bug-fix.

Status:Reviewed & tested by the community» Fixed

Sorry for letting this rot for so long!

Even though this is a change in behavior I could not think of any (realistic) way this would actually *break* stuff, so I committed this to all three current branches:

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes
Status:Closed (fixed)» Active

I in fact changed my mind on this. We shouldn't be doing any API changes in 7.x-2.x. Although loading integration files after the library files might still be the primary use-case, I can think of a couple use-cases for the opposite as well. So let's fix this properly in 3.x (i.e. allow both) and provide a backwards compatible way for this in 2.x. Patch coming up.

Status:Active» Needs review
new5.18 KB
PASSED: [[SimpleTest]]: [MySQL] 150 pass(es).
[ View ]

Here we go.

Version:7.x-2.x-dev» 7.x-3.x-dev
Status:Needs review» Active
new5.18 KB

Committed the attached patch to 7.x-2.x.

In the previous patch the test coverage was passing but not really valid. Because the parent tests get executed (potentially, depending on Batch API) in one request, the library file might already have been loaded, which makes the test pass even if the files are loaded incorrectly.

Moving to 7.x-3.x.

new6.25 KB

Oops here's the actual patch.

Version:7.x-3.x-dev» 7.x-2.2
Status:Active» Needs review
new1.08 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1855918-10-integration-files-order.patch.
[ View ]

Since the latest update, because of the above patch, I am getting PHP notices like

Notice: Undefined index: post-load integration files

Attached is the revisited patch, please review. (I wasn't sure if I should open a new issue for that, since the issue is related to this issue, actually is the consequence of the committed patch with the latest update.)

Status:Needs review» Needs work

The last submitted patch, 10: 1855918-10-integration-files-order.patch, failed testing.

Hm... thanks for the patch.

I don't see why those notices would appear, though. Have you tried a drush cc all? If that doesn't help could you help provide some debugging info, please, that would be awesome. It should be sufficient to just stick a debug(debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS)) at the top of libraries_load_files(). Thanks!

It may be unrelated, but could you be using Colorbox, pc-wurm?

I was seeing the notices you're talking about and with some digging it eventually it led me here: In my case, updating Libraries to 7.x-2.2 and downgrading colorbox to 7.x-2.4 made all notices go away and restored all functionality.