DateObject->difference not calculating correctly for future dates > 1 year away [#1858112]

If you call the difference method on the DateObject object and the following criteria are met:

$date2 parameter is before the date/time represented by the instantiated class (i.e. $this)
the gap between the dates spans one or more year boundaries
the $absolute flag is set to FALSE (i.e. we want a negative value out in the current case)

then you end up with an incorrect result. Essentially, the algorithms for adding or subtracting the whole or partial years in between the two dates appear not to take account of the $year_diff < 0 case.

This seems to be the case for week, month and day granularities.

Comment	File	Size	Author
#1	fix_for_incorrect_date_difference_arithmetic-1858112-1.patch	1.89 KB	tomdearden
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tomdearden CreditAttribution: tomdearden commented 4 December 2012 at 15:58

File	Size
fix_for_incorrect_date_difference_arithmetic-1858112-1.patch	1.89 KB

I've made a patch that I think addresses the above issue.

Comment #2

dusov CreditAttribution: dusov commented 17 December 2012 at 09:08

Patch works. Thank you.

Comment #3

jamix CreditAttribution: jamix commented 4 January 2013 at 13:31

Status:

Active

» Needs review

Works over here, too. Changing status to launch the test bot.

Comment #4

BWPanda CreditAttribution: BWPanda commented 20 March 2013 at 00:49

Status:

Needs review

» Reviewed & tested by the community

I was having the same problem:

// $membership_expiry['value'] = '2015-04-30 00:00:00'
$now = new DateObject();
$expiry_date = new DateObject($membership_expiry['value'], $membership_expiry['timezone']);

$difference = $expiry_date->difference($now, 'days', FALSE);
return $difference;

The above code was incorrectly returning a positive value. After applying the patch it correctly returns a negative value. RTBC.