Problem/Motivation

Not a big deal, but the current version of SMS Framework includes a typo in the admin section that reads "Configure send to phone functinality."

Proposed resolution

Created a patch to correct the typo; attaching in a comment to this issue.

Remaining tasks

Review needed?

User interface changes

New text reads "Configure send to phone functionality."

CommentFileSizeAuthor
#4 sms_sendtophone_module-1860830-4.patch1.91 KBalansaviolobo
#1 sms_sendtophone-1860830-1.patch806 bytesCOBadger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

COBadger’s picture

COBadger CreditAttribution: COBadger commented
Status: Active » Needs review
FileSize
sms_sendtophone-1860830-1.patch806 bytes

Patch to correct typo.

nmcclain’s picture

nmcclain CreditAttribution: nmcclain commented
Status: Needs review » Needs work

COBadger - thank you for this patch!! It tested out great, but ideally we need your help re-rolling the patch to be relative to the module directory.

Please check out this page and holler if you have questions!!
http://drupal.org/node/707484

Thanks!!!

nmcclain’s picture

nmcclain CreditAttribution: nmcclain commented

COBadger, I think the *only* change you need to make is to change to the module directory (sites/all/modules/smsframework) before making the patch file.

Thanks for your patience with this nit-picky request - it will make the module maintainer's job easier when they go to actually commit this patch.

alansaviolobo’s picture

alansaviolobo CreditAttribution: alansaviolobo commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
sms_sendtophone_module-1860830-4.patch1.91 KB

re-rolled the patch

COBadger’s picture

COBadger CreditAttribution: COBadger commented

alansaviolobo - thanks for the re-roll! Somehow I didn't follow through.

  • Commit 9e22c1c on 7.x-1.x by almaudoh: 
    Issue #1860830 by alansaviolobo, COBadger: Fixed sms_sendtophone.module...
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Assigned: COBadger » Unassigned
Status: Needs review » Fixed

Pushed to 7.x-1.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.