Missing docblocks from these three functions.

function user_is_anonymous() {
  // Menu administrators can see items for anonymous when administering.
  return !$GLOBALS['user']->uid || !empty($GLOBALS['menu_admin']);
}
function user_is_logged_in() {
  return (bool) $GLOBALS['user']->uid;
}
function user_register_access() {
  return user_is_anonymous() && (config('user.settings')->get('register') != USER_REGISTER_ADMINISTRATORS_ONLY);
}
Files: 
CommentFileSizeAuthor
#14 user-module-docblocks-1864216-14.patch1.17 KBmarvin_B8
PASSED: [[SimpleTest]]: [MySQL] 39,688 pass(es).
[ View ]
#8 user-module-docblocks-1864216.8.interdiff.txt1000 byteslarowlan
#8 user-module-docblocks-1864216.8.patch1.13 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 49,349 pass(es).
[ View ]
#1 user-module-docblocks-1864216.1.patch1.13 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 49,344 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 49,344 pass(es).
[ View ]

straight forward

Status:Needs review» Needs work

The last submitted patch, user-module-docblocks-1864216.1.patch, failed testing.

Status:Needs work» Needs review

#1: user-module-docblocks-1864216.1.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Looks good to me.

Status:Reviewed & tested by the community» Needs work

This patch does not follow our docs standards.
http://drupal.org/node/1354#functions

Assigned:Unassigned» jhodgdon

hi @jhodgdon, I can't see what I've missed, unless it needs to be Determines instead of Determine.
Please advise?

Assigned:jhodgdon» Unassigned

Correct. all the verb tenses are wrong.

Status:Needs work» Needs review
StatusFileSize
new1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 49,349 pass(es).
[ View ]
new1000 bytes

Thanks @jhodgdon, fixed in attached.

Status:Needs review» Needs work

The last submitted patch, user-module-docblocks-1864216.8.patch, failed testing.

Status:Needs work» Reviewed & tested by the community

Thanks! That looks fine. The test failure is obviously unrelated (and it's one that is already reported as a critical bug, the "deadlock" error on merge queries). I'll hit retest just in case.

#8: user-module-docblocks-1864216.8.patch queued for re-testing.

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)

Looks like we should backport this to 7.x, which is also missing the docs on at least some of the same functions.

Status:Patch (to be ported)» Needs review
StatusFileSize
new1.17 KB
PASSED: [[SimpleTest]]: [MySQL] 39,688 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

straight forward backport

(pardon the noise - just checking something with the testbot)

Status:Reviewed & tested by the community» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.