Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The default global theme setting for toggle_node_user_picture and toggle_comment_user_picture is TRUE so the test will always work. Even if you move theme settings out of variables and into CMI :)
Comment | File | Size | Author |
---|---|---|---|
#3 | 1864290-3.drupal8.user-picture-test.remove-vset.patch | 1.66 KB | alexpott |
#2 | 1864290-2.drupal8.user-picture-test.patch | 1.65 KB | alexpott |
#1 | 1864290-1.drupal8.user-picture-test.remove-vset.patch | 1.14 KB | alexpott |
Comments
Comment #1
alexpottPatch attached just removes the
variable_set()
's to show that they have no effect on the outcome on the test.Comment #2
alexpottPatch attached fixes the tests so that we are actually testing the ability to enable / disable user pictures on nodes and comments.
Comment #3
alexpottBah... mistake in the comment for the new test that completely turns off user pictures..
Comment #6
mgiffordThis still a concern in D8? Unassigned issue too.
Comment #15
quietone CreditAttribution: quietone as a volunteer commentedThis was fixed in #1712250: Convert theme settings to configuration system specifically added in comment #55.
Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.
Thanks!