The default global theme setting for toggle_node_user_picture and toggle_comment_user_picture is TRUE so the test will always work. Even if you move theme settings out of variables and into CMI :)

Files: 
CommentFileSizeAuthor
#3 1864290-3.drupal8.user-picture-test.remove-vset.patch1.66 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 49,365 pass(es).
[ View ]
#2 1864290-2.drupal8.user-picture-test.patch1.65 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 49,347 pass(es).
[ View ]
#1 1864290-1.drupal8.user-picture-test.remove-vset.patch1.14 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 49,046 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.14 KB
PASSED: [[SimpleTest]]: [MySQL] 49,046 pass(es).
[ View ]

Patch attached just removes the variable_set()'s to show that they have no effect on the outcome on the test.

StatusFileSize
new1.65 KB
PASSED: [[SimpleTest]]: [MySQL] 49,347 pass(es).
[ View ]

Patch attached fixes the tests so that we are actually testing the ability to enable / disable user pictures on nodes and comments.

StatusFileSize
new1.66 KB
PASSED: [[SimpleTest]]: [MySQL] 49,365 pass(es).
[ View ]

Bah... mistake in the comment for the new test that completely turns off user pictures..