As per #1628044-31: Implement magic for the table of attachments on issues -- instead of only passing $entity as context to hook_file_metadata_table_items_alter() why don't we pass all the context we've got, just like we do for hook_file_metadata_table_rows_alter()? Obviously, we wouldn't need $items inside $context, but it seems like all the rest of these might be useful/necessary in certain alter cases, and it costs us nothing to pass them all at once:

 *  - field: The field definition array.
 *  - instance: The field instance definition array.
 *  - entity: An object representing the entity the file field is attachted to.
 *  - entity_type: String with the type of entity the field is attached to.

Any objections?

Thanks,
-Derek

Comments

jthorson’s picture

Assigned: Unassigned » jthorson

No objections ... adding now.

jthorson’s picture

jthorson’s picture

Status: Needs review » Fixed

Committed in 25ca17b.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jthorson’s picture

Project: Attached Files Metadata Table » Extended File Field

Module name change.

  • Commit 25ca17b on 7.x-1.x, empty-file-2150029 by jthorson:
    Issues #1867102, #1867094 by jthorson: Improve rendering of hidden files...