Categorization with default taxonomy term reference field and views [#1870674]

This is branched from #1258026: Implement userpoint bundles (#2).

The issue title & description is mainly a placeholder until things gel.

Comment	File	Size	Author
#2	1870674-categorization-as-reference-2.patch	21.96 KB	mradcliffe
#2
#2	1870674-interdiff-with-1258032-3-do-not-test.patch	13.83 KB	mradcliffe
#2
#1	issue-1870674-full-diff.patch	10.82 KB	mradcliffe
#1
#1	issue-1870674-interdiff-with-field-patch-do-not-test.patch	2.59 KB	mradcliffe
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 19 December 2012 at 22:53

File	Size
issue-1870674-interdiff-with-field-patch-do-not-test.patch	2.59 KB

issue-1870674-full-diff.patch	10.82 KB

Here's a start to this by creating or using an existing a taxonomy term reference field from within userpoints_get_vid(). Not really tested.

Comment #2

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 29 December 2012 at 19:47

Status:

Active

» Needs review

File	Size
1870674-interdiff-with-1258032-3-do-not-test.patch	13.83 KB

1870674-categorization-as-reference-2.patch	21.96 KB

I really didn't like the whole userpoints_get_vid() thing. It's kind of wonky. I think the following should be easier to create tests:

I split out create and get into separate functions.
Created an install routine for it if taxonomy is enabled.
Created a settings form off of the settings page to create if taxonomy is enabled.

The first patch is a full diff with changes from all issues, and the second patch is a patch branched from #1258032: Allow to attach a points field to any entity and migrate the current hardcoded assignement to users.

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 29 December 2012 at 20:39

userpoints_get_vid() probably dates back to Drupal 5 or so, way before vocabularies had machine names. I totally agree that it's wonky, machine names should be used for that nowadays. But removing it completely and relying on a machine name instead will require an update function.

Comment #4

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 4 January 2013 at 20:23

Status:

Needs review

» Needs work

Any ideas about what to do with the userpoints_get_*_points functions? Can't use aggregation with a field table join without breaking no-SQL compatibility and can't do all of this in PHP/entity loads without running into scalability issues.

The only solution I can see is to mark this "won't fix" and have to live with tid as an entity property.

Comment #5

mradcliffe

he/him

English

CreditAttribution: mradcliffe commented 4 January 2013 at 21:33

Here's a thought after some quick IRC:

field_data_field_userpoints without some columns
delta	field_userpoints_points	field_userpoints_max_points	field_userpoints_tid
0	5	15	3
1	3	5	2
2	20	23	0

Use cases

Get all user's points from field: iterate through $account->field_userpoints['und'] and add points or max_points regardless of tid
Get (un)categorized points via query: query or entityfieldquery for field_userpoints where tid and entity_id are set.
Save transaction: would need to iterate through $account->field_userpoints['und'] to see if tid matches. If it does, then use the current delta, if not, create a new delta and set tid. Is there a race condition here and would it matter?