After the theme settings have been added, we need support for .install files for themes. The current workaround for D5 (http://drupal.org/node/177868) is very slow and an theme setting variables exists check will be executed once per page. It does not allow versioning of settings and so on.

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Everything required to do install files are fairly complex; I'm not sure we can justify this in 6.x, as it will be a significant effort. Yes, a lot of the code is there for modules and can theoretically be re-used, but currently there is very little concept of enabling or disabling a theme. This may have to wait for Drupal 7.

Instead, I would recommend packaging a module to go with your theme.

hass’s picture

hass CreditAttribution: hass commented
Version: 6.x-dev » 7.x-dev
hass’s picture

hass CreditAttribution: hass commented
Priority: Normal » Critical

I'd like to remind us about this issue.

hass’s picture

hass CreditAttribution: hass commented
Category: bug » feature
hass’s picture

hass CreditAttribution: hass commented
Priority: Critical » Normal

@merlinofchaos: Do you have an idea how much work this would be? Upgrading theme settings in D6 is a real mess... it could be much easier and reliable.

sun.core’s picture

sun.core CreditAttribution: sun.core commented
Version: 7.x-dev » 8.x-dev
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Version: 8.0.x-dev » 8.1.x-dev
Issue summary: View changes

Feature -> 8.1.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Related issues: +#2002606: Allow themes to provide services.yml
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Sounds like a duplicate of #2652542: Add .install file abilities for Themes

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Closed (duplicate)

It's not an exact duplicate but it's been active for 8 years+ so I'll close it and let someone who wants to work on this open a new issue if #2652542: Add .install file abilities for Themes doesn't resolve the crux of the issue. Thanks @dawehner I was looking for that one actually:)

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Issue summary: View changes
Status: Closed (duplicate) » Needs review

Other issue doesn't cover update hooks, re-opening.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Closed (duplicate)
Related issues: +#474684: Allow themes to declare dependencies on modules

#474684: Allow themes to declare dependencies on modules would allow update hooks though, so moving to duplicate of that issue.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Related issues: -#474684: Allow themes to declare dependencies on modules

#474684: Allow themes to declare dependencies on modules