Problem/Motivation

When using displays like content panes, the view doesn't get any natural path. In the setting 'link display' there is an option to set a custom path, which may be useful for example when using exposed filters in blocks. However, the exposed block doesn't pick up this setting.

Proposed resolution

Make the exposed setting pick up the setting.

Remaining tasks

Review patch. Iterate if necessary.

User interface changes

–

API changes

–

CommentFileSizeAuthor
#26 1874838-26.patch1.64 KBpcambra
#10 vdc-1874838-10.patch813 bytesolli
#7 drupal-1874838-7.patch806 bytesdawehner
#5 views-1874838-5.patch643 bytesdawehner
#1 1874838-1-use_link_display_in_exposed_blocks.patch727 bytesItangalo

Issue fork drupal-1874838

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented
Status: Active » Needs review
FileSize
1874838-1-use_link_display_in_exposed_blocks.patch727 bytes

Patch attached.

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented

There were some related issues about this:

#1023074: Exposed filter forms with block view with a feed display submits to the feed URL
#525592: views_embed_view() + exposed filters button = homepage redirect
#607606: Exposed filter in block always defaults to filtering the feed view

They are either marked as 'closed (works as designed)' or 'fixed'. I think this approach/patch solves the issues.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thanks for working on this issue! I saw #1329776: Utilize the custom_url/link_url view options in the get_path of the context display which seems to be really similar, so i'm wondering whether we should also check that the link type is custom_url?

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented

@dawehner: It seems to be exactly the same issue. The patch above is against views_plugin_display.inc, so it would affect *all* display types. I think it makes sense, but I really don't know the Views architecture well enough to say what problems might arise.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
FileSize
views-1874838-5.patch643 bytes

So i guess this is safe to commit. Any objections?

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented

Seems good to me!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Needs review
FileSize
drupal-1874838-7.patch806 bytes

Perfect. Here is a 8.x version.

Status: Needs review » Needs work

The last submitted patch, drupal-1874838-7.patch, failed testing.

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented
Status: Needs work » Closed (fixed)

It seems this patch, or some code very similar to it, is now in Views core.

olli’s picture

olli CreditAttribution: olli commented
Project: Views (for Drupal 7) » Drupal core
Version: 7.x-3.x-dev » 8.x-dev
Component: exposed filters » views.module
Status: Closed (fixed) » Needs review
Issue tags: +VDC
FileSize
vdc-1874838-10.patch813 bytes

I can't find #7 in 8.x.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs tests

Good catch! I guess we need to add a test here.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

10: vdc-1874838-10.patch queued for re-testing.

Prashant.c queued 10: vdc-1874838-10.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: vdc-1874838-10.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pcambra made their first commit to this issue’s fork.

pcambra opened merge request !1403

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra at Cambrico for Farmier commented
Version: 8.9.x-dev » 9.3.x-dev
Issue summary: View changes
Status: Needs work » Needs review
pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra at Cambrico for Farmier commented
FileSize
1874838-26.patch1.64 KB

Adding a patch to make it easier to include it in composer.json workflows

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented
Related issues: +#2844823: Views exposed form action incorrect for embedded views' displays with other displays with paths

Cross feedback in #2844823-32: Views exposed form action incorrect for embedded views' displays with other displays with paths

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

For the tests requested in #11

Did not test.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.