Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- Some comments were inconsistent with the rest of core comments.
- Renamed the "wysiwyg-tabs" and "wysiwyg" toolgroups (in the per-field Edit toolbar) to "wysiwyg-floated" and "wysiwyg-main", so that it'd be more generally useful. The "tabs" stuff was only relevant for Aloha Editor. The difference between the two is: one of them is floated to the right (on LTR, to the left on RTL), to be next to the "Save" and "Close" buttons; the other one is full-width.
- Added the ability to add an ID attribute to toolgroups.
- I added ID attributes to both "wysiwyg" toolgroups by default. This is necessary for some WYSIWYG editors; we don't want random IDs to be attached, hence we want to provide this already.
- I noticed when testing Edit + Editor (#1873500: CKEditor + Edit) that behaviors would get attached (in this case: text (WYSIWYG) editor attaching) even on the form that is hidden by Edit from the end user, that is solely used as a syncing/data transport mechanism. I added an override that will prevent that.
Comment | File | Size | Author |
---|---|---|---|
#3 | 1875874-2.patch | 5.45 KB | frega |
#3 | interdiff.txt | 2.55 KB | frega |
#1 | 1875874-1.patch | 6.2 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersComment #3
frega CreditAttribution: frega commentedSlightly reworked the patch from #1.
Other than that, it looks to go I could be RTBC'd :)
Comment #4
Wim LeersThanks! The first makes sense, and the second is a good catch.
Comment #5
Wim LeersOn second thought, that's all the review we really needed :) After having discussed this with @frega: RTBC (assuming it comes back green — almost 4 hours later and still no test results :/).
Comment #7
frega CreditAttribution: frega commented#3: 1875874-2.patch queued for re-testing.
Comment #8
Wim LeersComment #9
webchickCommitted and pushed to 8.x. Thanks!