SQLite error: "there is already an index named entityform_type"

Ok, thinking about how to fix this.

Can you let me know what version of SQLite you are using?

Thanks

Same problem, how can i fix it?

I never heard back from him about my question in #2. Can you let me what version of SQLite you are using?

I'm using sqlite 3.

@Mentor, please confirm that you are using

SQLite 3.3.7 or higher

From http://drupal.org/requirements
Before I investigate this problem I want to make sure that this is happening with the recommended version of SQLite

Yes, i have SQLite 3.7.7.1.

@Mentor, ok thanks.

I have attached that renames the index by dropping and re-adding it.

Let me know if this works for you.

changing to needs review

patch is against dev version

#8: entityform-rename_type_index-1876872-8.patch queued for re-testing.

I don't have SQLite installed. I have tested this with my setup that uses mysql but will need someone to test it on SQLite.

I'm unable to apply patch. How can i do this?

Mentor: see http://drupal.org/node/1378306/git-instructions/7.x-1.x

Well, the patch doesn't work for me. I'm using sqlite ver 3.7.9

jeyram@PCRam:~/drupal/sites/all/modules/entityform$ git apply -v entityform-rename_type_index-1876872-8.patch
Checking patch entityform.install...
Applied patch entityform.install cleanly.

jeyram@PCRam:~/drupal/sites/all/modules/entityform$ drush cc theme-registry
'theme-registry' cache was cleared in /home/jeyram/Documents/quick-drupal-20121003184025/drupal#default                                                                       [success]

jeyram@PCRam:~/drupal/sites/all/modules/entityform$ drush en entityform
The following extensions will be enabled: entityform
Do you really want to continue? (y/n): y
WD php: PDOException: SQLSTATE[HY000]: General error: 1 there is already an index named entityform_type: CREATE TABLE {entityform_type} (                                     [error]
id INTEGER PRIMARY KEY AUTOINCREMENT, 
type VARCHAR(255) NOT NULL, 
label VARCHAR(255) NOT NULL DEFAULT '', 
weight INTEGER NOT NULL DEFAULT 0, 
data TEXT NULL DEFAULT NULL, 
status INTEGER NOT NULL DEFAULT 1, 
module VARCHAR(255) NULL DEFAULT NULL
);
; Array
(
)
 in db_create_table() (line 2717 of /home/jeyram/Documents/quick-drupal-20121003184025/drupal/includes/database/database.inc).
PDOException: SQLSTATE[HY000]: General error: 1 there is already an index named entityform_type: CREATE TABLE {entityform_type} (
id INTEGER PRIMARY KEY AUTOINCREMENT, 
type VARCHAR(255) NOT NULL, 
label VARCHAR(255) NOT NULL DEFAULT '', 
weight INTEGER NOT NULL DEFAULT 0, 
data TEXT NULL DEFAULT NULL, 
status INTEGER NOT NULL DEFAULT 1, 
module VARCHAR(255) NULL DEFAULT NULL
);
; Array
(
)
 in db_create_table() (line 2717 of /home/jeyram/Documents/quick-drupal-20121003184025/drupal/includes/database/database.inc).
Drush command terminated abnormally due to an unrecoverable error.                                                                                                            [error]

@jeyram does it not work on an existing or new install?

more info needed

I'm suffering from this on sqlite 3.6.20.

first for other sufferers how to cure the WSOD:

drush sqlq "update system set status=0 where name='entityform';"
drush cc all
drush sqlq "drop table entityform;"

(the last line is important because although the module is marked uninstalled there IS an entityform table left.)

the i applied the patch to dev and tested fresh install, but got same exception as above #16.
reviewing the code - no wonder.
fixed the fix and made a happy clean install.
patch flying in.

The patch works for me

19: 0001-Issue-1876872-by-tedbow-haxney-axel.rutz-Fixed-SQLit.patch queued for re-testing.

Patch works for me too. I don't understand what's the problem with the 'type' index though. Is 'type' a reserved word in sqlite?

rtbc as of #20&#22

19: 0001-Issue-1876872-by-tedbow-haxney-axel.rutz-Fixed-SQLit.patch queued for re-testing.

I am going to re-test to make it sure it still applies.
Thanks,

OK, testbot is happy.

Above patch does not apply any more, rerolling.

Wrong branch.

The same in here, patch works fine.

Reproducible steps:

1. Clone this sandbox.
2. Remove this patch from `contrib-core.yml`.
3. Build sandbox via `make`.

It should fail:

exception 'PDOException' with message 'SQLSTATE[HY000]: General error: 1 there is already an index named [error]

This is a bit strange because core has this in node, field, dblog and feeds also does this. Do you have to patch any of those as well?

Re-rolled it for entityform_update_7007, and committed to -dev. I see that it's the _type that's likely causing this and none of the other modules tables are named that way.

This issue fix seems to have introduced another one. The index rename change below is being done under $schema['entityform']

<?php
-      'type' => array('type'),
+      'type_index' => array('type'),
?>

while the function entityform_update_7006(&$sandbox = NULL) is targeting the $schema['entityform_type']

<?php
+  db_drop_index('entityform_type', 'type');
+  db_add_index('entityform_type', 'type_index', array('type'));
?>

Noticed this error when I installed https://www.drupal.org/project/schema

please open a new issue, I'm not totally following the issue you have.