Related to #1874300: Remove $entity_type argument from field.module functions that receive a single $entity

CommentFileSizeAuthor
#6 good-bye-user-label-1879200-6.patch3.75 KBpcambra
#5 good-bye-user-label-1879200-5.patch3.76 KBswentel
#1 good-bye-user-label-1879200-1.patch3.57 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
good-bye-user-label-1879200-1.patch3.57 KB

Good by useless wrapper function :)

Status: Needs review » Needs work

The last submitted patch, good-bye-user-label-1879200-1.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented 
Two entities loaded by uid without caring about property translatability.	Other	EntityTranslationTest.php	268	Drupal\system\Tests\Entity\EntityTranslationTest->testMultilingualProperties()

Hm, another random error? Could be possible after the EntityNG patch went in...

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

#1: good-bye-user-label-1879200-1.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
good-bye-user-label-1879200-5.patch3.76 KB

rerolled

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Issue summary: View changes
FileSize
good-bye-user-label-1879200-6.patch3.75 KB

Here's a simple re roll

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: Remove uneeded $entity_type argument from entity type callbacks » Change notice: Remove uneeded $entity_type argument from entity type callbacks
Priority: Normal » Major
Status: Reviewed & tested by the community » Active

Committed/pushed to 8.x. Needs a very short change notice.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Needs change record, +Missing change record

Discussed with @berdir. At this point an 8.x to 8.x change record is probably not valuable, so we should just make sure the existing entity API change records are correct.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Title: Change notice: Remove uneeded $entity_type argument from entity type callbacks » Remove uneeded $entity_type argument from entity type callbacks
Priority: Major » Normal
Status: Active » Fixed
Issue tags: -Needs change record, -Missing change record

Updated [#1217104] a bit, wasn't able to find any references to title or url callback functions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.