Problem/Motivation

I made some changes in Symfony (https://github.com/symfony/symfony/pull/6500, https://github.com/symfony/symfony/pull/6501, and https://github.com/symfony/symfony/pull/6503) to be able to remove some hacks that were done in Drupal when integrating Symfony. Updating the Symfony deps will allow a follow-up patch that will get rid of some of these hacks.

Proposed resolution

The patch is just an update of dependencies when running composer update.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, composer-update.patch, failed testing.

Berdir’s picture

You probably want to exclude guzzle from the update. The 3.0.7 release is broken as it references a plugin that is not a dependency.

It's already fixed but needs a new release before we can update it. There's a separate issue for it: #1875818: Update composer.json to use the latest stable 3.0.x version of Guzzle

fabpot’s picture

Status: Needs work » Needs review
FileSize
273.26 KB

The new patch only updates Symfony

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Spiffy.

webchick’s picture

#3: composer-update_3.patch queued for re-testing.

webchick’s picture

Category: feature » task

There's no reason for this to be blocked on thresholds, so re-assigning as a task.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

This patch is no longer applying for me:

$ git apply --index composer-update_3.patch 
error: patch failed: core/vendor/autoload.php:4
error: core/vendor/autoload.php: patch does not apply
error: patch failed: core/vendor/composer/autoload_real.php:2
error: core/vendor/composer/autoload_real.php: patch does not apply
error: patch failed: core/vendor/composer/installed.json:674
error: core/vendor/composer/installed.json: patch does not apply

My, that drop moves fast. :)

fabpot’s picture

Status: Needs work » Needs review
FileSize
285.38 KB

New patch from latest origin/8.x

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

gogo!

chx’s picture

Issue tags: +Avoid commit conflicts

Tagging.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alexpott’s picture

Issue tags: -Avoid commit conflicts

Cleaning up tags