In commerce_fieldgroup_panes_commerce_checkout_pane_info() the title value is ran through check_plain() but commerce runs the titles through check_plain when creating the form and so the titles get double-escaped resulting in anything that should be escaped getting garbled (eg an apostrophe), patch incoming...

CommentFileSizeAuthor
#1 commerce_fieldgroup_panes-redundant_check_plain-1883324-1.patch720 bytesmjpa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mjpa’s picture

mjpa CreditAttribution: mjpa commented
Status: Active » Needs review
FileSize
commerce_fieldgroup_panes-redundant_check_plain-1883324-1.patch720 bytes

The patch...

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I still have double escaping but at least it's not triple escaped.

& became &

Thanks @mjpa

  • pcambra committed 076d63f on 7.x-1.x authored by mjpa 
    Issue #1883324 by mjpa: Redundant check_plain
pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra at Cambrico commented
Status: Reviewed & tested by the community » Fixed

Better than nothing, thanks for the patch and the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.