Responsive layout & Smartplayer API support [#1883738]

Motivation

We have a client that needs these.

Proposed resolution

The attached patch provides these as options in various areas.

User interface changes

"Brightcove Smart Player" is available as a formatter in Brightcove Video fields.

Added support to the Players (http://example.com/admin/config/media/brightcove/players) for enabling responsive layout to the template.

API changes

There is some minimal CSS supplied for the responsive layout but a themer will likely want to compliment this with something more.

Comment	File	Size	Author
#8	1883738-8-brightcove_responsive_layout-7.x-4.x-dev.patch	4.75 KB	grndlvl
#7	brightcove-responsive_layout_and_smartplayer_api-1883738-7d.patch	14.89 KB	leewillis77
#6	brightcove-responsive_layout_and_smartplayer_api-1883738-6.patch	14 KB	Gold
#5	brightcove-responsive_layout_and_smartplayer_api-1883738-5.patch	14.12 KB	Gold
#4	brightcove-responsive_layout_and_smartplayer_api-1883738-3.patch	13.97 KB	Gold
#2	brightcove-responsive_layout_and_smartplayer_api-1883738-2.patch	14.08 KB	Gold
	brightcove-responsive_layout_and_smartplayer_api.patch	9.94 KB	Gold

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Gold

they/them

20 minutes in the future

CreditAttribution: Gold commented 9 January 2013 at 04:37

Status:

Needs review

» Needs work

nuts. Somehow, I missed a file. There's also https support that needs to be added but I'm out of time today. WIll make this a priority in the morning.

Comment #2

Gold

they/them

20 minutes in the future

CreditAttribution: Gold commented 9 January 2013 at 20:03

Status:

Needs work

» Needs review

File	Size
brightcove-responsive_layout_and_smartplayer_api-1883738-2.patch	14.08 KB

Okay, this one got the extra files and includes support for adding the secureConnections parameter to tell BC that it needs to use https when we are.

Comment #3

Gold

they/them

20 minutes in the future

CreditAttribution: Gold commented 9 January 2013 at 20:08

Status:

Needs review

» Needs work

Sigh... Coffee hasn't kicked in. Fixing a couple of paths.

File	Size
brightcove-responsive_layout_and_smartplayer_api-1883738-3.patch	13.97 KB

Comment #5

Gold

they/them

20 minutes in the future

CreditAttribution: Gold commented 9 January 2013 at 21:13

File	Size
brightcove-responsive_layout_and_smartplayer_api-1883738-5.patch	14.12 KB

Moving some template logic into a preprocess function. This should hopefully be the last update.

Comment #6

Gold

they/them

20 minutes in the future

CreditAttribution: Gold commented 9 January 2013 at 23:15

File	Size
brightcove-responsive_layout_and_smartplayer_api-1883738-6.patch	14 KB

minor update to the template. Using $var instead of $variables['var'] in the template now.

Comment #7

leewillis77 CreditAttribution: leewillis77 commented 29 May 2013 at 16:25

File	Size
brightcove-responsive_layout_and_smartplayer_api-1883738-7d.patch	14.89 KB

Thanks for the previous patch. We've just been looking at this and tried out the patch in #6. I've provided an updated patch that is a re-roll of patch #6 against 7.x-3.x with the following additions:
* hook_schema amended to include the new make_responsive field on brightcove_players table
* hook_update_7031 added to add the make_responsive field as an update if it doesn't already exist

I'm not sure what data type you had for this on your install, but I've set it to a NOT NULL INT with a default of 0 in the attached patch which seems to work for us.

Comment #8

grndlvl CreditAttribution: grndlvl commented 4 December 2013 at 13:21

Issue summary:

View changes

File	Size
1883738-8-brightcove_responsive_layout-7.x-4.x-dev.patch	4.75 KB

Needed functionality in 7.x-4.x, however, the patch obviously didn't apply cleanly. Due to time constraints I only implemented the bare minimum to get responsive videos working for my setup. Here is what I have so far.