The logic of Line 152 in term_permissions.module doesn't fit with the comments on line 150-151 above -- it should be "if (count($options) < 1)" or "if (count($options) == 0)" instead of "if (count($options) <= 1)"

CommentFileSizeAuthor
#2 user_count-1885338-2.patch648 bytesadiaz
#1 user_count-1885338-1.patch546 bytesMiSc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MiSc’s picture

MiSc CreditAttribution: MiSc commented
Status: Active » Needs review
FileSize
user_count-1885338-1.patch546 bytes

Suggested patch is attached.

adiaz’s picture

adiaz
he/him
Primary language Spanish
Location San José, Costa Rica
CreditAttribution: adiaz commented
Issue summary: View changes
FileSize
user_count-1885338-2.patch648 bytes

I can confirm the error and the proposed solution.

Attaching a new version of patch, as #1 can't be applied because it has absolute paths.

Pablo Gosse’s picture

Pablo Gosse CreditAttribution: Pablo Gosse commented

Thx for this patch. Applies cleanly for me. Moving this to RTBC as this is an incredibly simple but important change.

Pablo

Pablo Gosse’s picture

Pablo Gosse CreditAttribution: Pablo Gosse commented
Status: Needs review » Reviewed & tested by the community

Moving to RTBC. Simple fix. Can we get this committed into the DEV branch?

Pablo

  • roborn committed 0f8273f on 7.x-1.x authored by MiSc 
    Issue #1885338 by adiaz, MiSc: Prevent users without any term...
roborn’s picture

roborn CreditAttribution: roborn at Frontkom for Norwegian University of Life Sciences commented
Status: Reviewed & tested by the community » Closed (fixed)