Add mobile friendly meta tags to the maintenance page

Shouldn't there also be a tag for "meta tags"?

I copied the same solution from the template_preprocess_html in the core/includes/theme.inc file and it seems to work.

Let me know what do you think :)

Absolutely, I will do it today when I have some time. Thanks!!

I completely forgot about this issue. Tested and the patch applies well so let see what says the Testbot again and RTBC ;)

#6: mobile-friendly-meta-tags-maintenance-1887800-6.patch queued for re-testing.

It seems RTBC.

Now that we can test the interactive installer we should add a test to check that these tags are added.

You should be able to assert that the headers are there in the setUp method of \Drupal\system\Tests\InstallerTest

Test created but not sure if it's correct. Feel free to blame on me :)

Another try copied from: DefaultMobileMetaTagsTestCase test in core/modules/system/system.test file.

I don't know why it gives me an error when I add a new test case in the InstallerTest.php. I there is only one test case, it works correctly. Maybe other people can help me with this issue because I don't have enough experience with PHP Unit testing :(

Ok, now #6 patch and the test.

The patch in #6 doesn't work. That might explain why the tests fail in #15.

Lewis, you are calling a "_theme_mobile_meta_tags" function twice, but never define it.

Also, this issue is a bug, not a task. The CSS is designed to work on small screens, but the lack of metatags means that mobile devices will fake a much larger desktop-sized viewport.

I was going to live demo the installer in an iPhone tomorrow, but can't until I fix this bug.

@Lewis, Oh! I take it back. I see how that function is defined. Sneaky little patch. :-)

I'm going to try to get this patch to green.

I don't like the _theme_mobile_meta_tags() function name. I've renamed it to drupal_add_mobile_meta_tags(), which… sucks less.

And here's a test that actually works. It was tricky to write. Copied chunks from both DefaultMobileMetaTagsTest and from InstallerTranslationTest.

Here's a new patch that refactors a lot of the underlying plumbing. It makes the meta tag test much smaller. But I'm fairly certain it causes several warnings, but maybe no failures. Needs work, but let's let the testbot have a go.

Re-rolled patch for MWDS show-and-tell. Should still fail.

I'm going to move the installer test refactoring to a new issue, make this issue a dependency on this one. Also, I'll need to take a look at Lewis' latest suggestion.

The refactoring of the installer tests has moved to: #2067919: Refactor installer tests so they don't have to override Setup().

Here's the rerolled patch with the simple tests that require that other issue.

I think this isn't necessary anymore, so marking as closed. Please re-open if I'm wrong.