These notices are generated with and without timezone argument.

CommentFileSizeAuthor
#6 date_migrate_generates-1888268-6.patch1.14 KBalcroito
#4 date-undefined_index_timezone-1888268-4.patch451 byteskplanz
#1 undefined_index_timezone-1888268-1.patch495 bytesmikran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikran’s picture

mikran CreditAttribution: mikran commented
Status: Active » Needs review
FileSize
undefined_index_timezone-1888268-1.patch495 bytes
mikran’s picture

mikran CreditAttribution: mikran commented
Assigned: Unassigned » mikran

I noticed the mention over at #2034231: [META] Integrated patch for migration changes. This issue is kind of old but I should still have the migrate somewhere so I'll try to find it and provide more details.

Status: Needs review » Needs work

The last submitted patch, undefined_index_timezone-1888268-1.patch, failed testing.

kplanz’s picture

kplanz CreditAttribution: kplanz commented
Issue summary: View changes
FileSize
date-undefined_index_timezone-1888268-4.patch451 bytes

I have the same problem.
Attached an updated patch which works with the current 7.x-2.x-dev version.

kplanz’s picture

kplanz CreditAttribution: kplanz commented
Status: Needs work » Needs review

Change status.

alcroito’s picture

alcroito CreditAttribution: alcroito commented
FileSize
date_migrate_generates-1888268-6.patch1.14 KB

Attaching a patch that IMO is better, because instead of setting the timezone before even $return is defined, it should be set for the particular conditional branch, also making sure that if the date value is NULL, timezone should also be NULL.

mikran’s picture

mikran CreditAttribution: mikran commented
Assigned: mikran » Unassigned
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Reviewed & tested by the community

Fixes the notices, thank you.

ohthehugemanatee’s picture

ohthehugemanatee CreditAttribution: ohthehugemanatee commented

worked for me, too. I still have other issues when the imported date is unix 0, but that's a separate issue. Seems RTBC.

ayalon’s picture

ayalon CreditAttribution: ayalon commented

Thanks! Tested and working! Please commit it.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

RTBC again.

opi’s picture

opi
Primary language French
CreditAttribution: opi commented

RTBC for me, #6 fixes every notices, thanks.

Chewie’s picture

Chewie CreditAttribution: Chewie commented

Patch for Date 7.28 version https://www.drupal.org/node/2451027

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.