Figure out the most used html tags and let people use it in views [#1888698]

Comment	File	Size	Author
#11	views-html-tags-1888698-11.patch	616 bytes	hussainweb

#7	views-most_used_html_tags-1888698-7.patch	351 bytes	nagwani

#1	views-most_used_html_tags-1888698-1.patch	365 bytes	nagwani

Comment #1

nagwani CreditAttribution: nagwani commented 24 January 2013 at 18:58

Status:

Active

» Needs review

File	Size
views-most_used_html_tags-1888698-1.patch	365 bytes

Added a few HTML tags

Log in or register to post comments

Comment #2

dawehner

German

CreditAttribution: dawehner commented 24 January 2013 at 21:38

Thanks for working on that!

We certainly also want stuff like section.

Log in or register to post comments

Comment #3

droplet CreditAttribution: droplet commented 24 January 2013 at 22:27

+++ b/core/modules/views/config/views.settings.ymlundefined
@@ -33,3 +33,8 @@ field_rewrite_elements:
+  a: A
+  br: BR
...
+  img: IMG

wrap with br/img / a ?

Log in or register to post comments

Comment #4

dawehner

German

CreditAttribution: dawehner commented 24 January 2013 at 23:25

Yeah droplet that's a good point.

We just want to have HTML tags which are used as wrappers, so none of those actually are.

Log in or register to post comments

Comment #5

nagwani CreditAttribution: nagwani commented 25 January 2013 at 07:13

I assume we want HTML 5 wrapper tags as well. Will update with those

Log in or register to post comments

Comment #6

nagwani CreditAttribution: nagwani commented 25 January 2013 at 07:13

Assigned:	Unassigned	» nagwani
Status:	Needs review	» Needs work

Log in or register to post comments

Comment #7

nagwani CreditAttribution: nagwani commented 25 January 2013 at 08:48

Status:

Needs work

» Needs review

File	Size
views-most_used_html_tags-1888698-7.patch	351 bytes

Removed not wrapper tags. Added aside tag.

Based on some research on internet, I am not sure if we would want to allow the section tag.
http://html5doctor.com/downloads/h5d-sectioning-flowchart.png
http://html5doctor.com/avoiding-common-html5-mistakes/

Log in or register to post comments

Comment #8

samhassell CreditAttribution: samhassell commented 5 February 2013 at 13:31

How would <ul> and <li> work in this case?

Applying <ul> gives:

<div class="views-field views-field-title">        
  <ul class="field-content">
    <a href="/node/8">Eu Neo</a>
  </ul>  
</div>

I can't see any way to rewrite this into something that makes sense. Even if you wrap the <a> in an <li>, an unordered list with one item doesn't make sense.

Log in or register to post comments

Comment #9

dawehner

German

CreditAttribution: dawehner commented 5 February 2013 at 20:45

I guess some of those could help: article, section, aside, details?, maybe more.

Log in or register to post comments

Comment #10

dawehner

German

CreditAttribution: dawehner commented 1 July 2013 at 12:01

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #11

hussainweb

English

CreditAttribution: hussainweb commented 9 July 2013 at 05:23

Status:

Needs review

» Needs work

File	Size
views-html-tags-1888698-11.patch	616 bytes

How about this list (attached)?

Some of the omissions, and the reason why I omitted them:

main - There should only be one main tag in a document, so I don't think it is a good candidate for views.
figcaption - This is generally within figure.
sup, sub - This is generally always used with other inline text.
Other inline tags like mark, dfn, time, abbr, etc... for the same reason.

What are your thoughts on the omissions?

On the other hand, what about the list attached? I realize it is rather an extensive list. Which ones do you think we should keep?