Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Repeat Every Year with relative date don't work.
If I enter date: 8 January 2012 and Repeat option:
Repeat Yearly Every 1 Year on Second Sunday of January
Repeat stop 01/01/2099
I don't see date 13 January 2013 and other dates in node view and I can't get this dates from Views.
On page mysite.com/node/12345/repeats I see only first date (8 January 2012) and repeat rules.
Comment | File | Size | Author |
---|---|---|---|
#17 | 1888968-date-repeat-bymonth-16-MUSTFAIL.patch | 4.99 KB | cafuego |
#16 | 1888968-date-repeat-bymonth-16.patch | 6.68 KB | cafuego |
#8 | only-test2.patch | 5.24 KB | podarok |
#1 | date_repeat-yearly_bymonth-1888968-1.patch | 2.26 KB | Matthew Davidson |
Comments
Comment #1
Matthew Davidson CreditAttribution: Matthew Davidson commentedThere's just no code for handling YEARLY repeats with BYMONTH rule parts in _date_repeat_calc(). This patch appears to do the trick. Please check it out for logic flaws; dates are hard, and my brain is really old and soggy.
Comment #2
Matthew Davidson CreditAttribution: Matthew Davidson commented... and I can never remember to change issue status.
Comment #3
Tobias Xy CreditAttribution: Tobias Xy commentedPatch #1 solved the problem for me!
Comment #4
breezeweb CreditAttribution: breezeweb commentedI can confirm Patch #1 fixes the problem also. Thanks!
Can this be patch be committed to HEAD as soon as possible? This is a significant functionality bug where a basic feature simply doesn't work at all.
Comment #4.0
breezeweb CreditAttribution: breezeweb commentedchange link
Comment #5
vijaycs85Thanks for working on this issue. This case doesn't look like a critical as a module point of view. Downgrading to Major.
Add comment in new line and would be great to have an issue with details and update issue link here?
Haven't tested manually yet, but looks like we can add some test to cover this case.
Comment #6
podaroktest
shoud fail
Comment #8
podarokhate windows
should fail but proper patch file format
Comment #10
podarokthe trouble is that with and without https://drupal.org/comment/7086712#comment-7086712 patch function returns the same data.
Problem is not only in this place or I did something wrong
is pure evil... needs re-factoring this spaghetti code
Comment #11
sashken2 CreditAttribution: sashken2 commentedPlease add patch #1 in next realese.
Comment #12
phoehne CreditAttribution: phoehne commentedpatch #1 works perfect. and it should be released because you can get an infinite loop if you use these types of dates with a stop-rule bound to number of occurrences which brings your site down!
(#10)Perhaps there are more problems, but i think its better than nothing.
greetings peter.
Comment #13
phoehne CreditAttribution: phoehne commentedpatch #1: used it for a while now - no problems
Comment #16
cafuego CreditAttribution: cafuego commentedRerolled the patches into one, and these should now apply as well.
Comment #17
cafuego CreditAttribution: cafuego commented... and a tests-only version of the patch from #16.
Comment #18
parvind87 CreditAttribution: parvind87 at Icreon commentedIn Drupal 7.37, this patch no longer needed.
Comment #19
Chris Matthews CreditAttribution: Chris Matthews commentedComment #20
Gribnif CreditAttribution: Gribnif commentedI don't understand why this issue was closed. Changes in core in no way affected this issue. I can confirm that this patch is still needed. (It needs to be re-rolled to work against the current development branch, though.)