The variable 'smtp_library' seems to be for drupal 6 only. It's confusing for developers that it still exists in the drupal-7 version of the module. I guess it woudl be completely safe just to remove it (but of course keep the code in the uninstall-hook).

CommentFileSizeAuthor
#14 Screen shot 2016-01-30 at 10.07.06 PM.png30.05 KBAnonymous (not verified)
#6 smtp-n1889278-6.patch2.09 KBDamienMcKenna
#2 smtp-1889278-2-remove_smtp_library_variable.patch1.97 KBSimon Georges
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gnucifer’s picture

gnucifer CreditAttribution: gnucifer commented

'smtp_on' can also be removed I guess?

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Category: bug » task
Status: Active » Needs review
FileSize
smtp-1889278-2-remove_smtp_library_variable.patch1.97 KB

Ok, let's remove smtp_library. Changing category as it is not really a bug.

This patch is part of the #1day1patch initiative.

wundo’s picture

wundo CreditAttribution: wundo commented
Status: Needs review » Needs work

Simon,
looks like you're touching more code than just removing the smtp_library variable, could you explain what you're doing?

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented

Well, everywhere there's mention of smtp_library (outside of .install), I'm trying to adapt the code. Since mimemail does not define it either, there's a part of the code that could (should?) go too. I just let the status test using the smtp_on variable, but I think the rest is useless. It clearly needs a thorough review.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented

As #1 is mentionning smtp_on, I'm cross-referencing #1663008: Variable "smtp_on" doesn't actually disable anything....

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
smtp-n1889278-6.patch2.09 KB

I've updated the patch to add an update script that deletes the variable, and then there's no need for the lines in smtp_uninstall.

Status: Needs review » Needs work

The last submitted patch, 6: smtp-n1889278-6.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna as a volunteer commented
Title: Remove smtp_library from 7.x-version » Remove smtp_library variable from 7.x-version
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna as a volunteer commented
Status: Needs work » Needs review

The test failed because of a bug in drupalci: #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna as a volunteer commented

The tests failed because of a bug in DrupalCI: #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present

Status: Needs review » Needs work

The last submitted patch, 6: smtp-n1889278-6.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna as a volunteer commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna as a volunteer commented
Parent issue: » #2651788: Plan for SMTP 7.x-1.4 release

This would be safe to include in the next release.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented
FileSize
Screen shot 2016-01-30 at 10.07.06 PM.png30.05 KB

This installed perfect for me. That said, it was in a clean install with no other patches applied. I wanted to check in ideal conditions. Let me know if I should test this patch with other patches applied as well.

gadaniels72’s picture

gadaniels72 CreditAttribution: gadaniels72 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This worked for me as well. Tested both on a clean install and with some of the other needs review patches installed.

  • wundo committed 46bee9d on 7.x-1.x authored by DamienMcKenna 
    Issue #1889278 by DamienMcKenna, Simon Georges: Remove smtp_library...
  • wundo committed b4d88e7 on 7.x-1.x authored by DamienMcKenna
    Issue #1889278 by DamienMcKenna, Simon Georges: Remove smtp_library...
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.