references-dialog.js: various bugfixes and improvements [#1889582]

references-dialog.js needs various bugfixes and performance improvements:
- variable caching instead of writing the same jQuery statement $(...) multiple times
- missing line endings (;)
- wrong "undefined" comparisons
- context bugfix for $('.' + key + ' a.references-dialog-activate')

Surprisingly, the context bugfix was no problem for jQuery 1.5 (?), even though it's wrong.
But I noticed it was if you're using a higher jQuery version (with for example the jQuery Update module).

Comment	File	Size	Author
#2	references_dialog-various_js_bugfixes-1889582-2.patch	7.13 KB	jover
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jover

Dutch

Leuven 🇧🇪

CreditAttribution: jover commented 15 January 2013 at 21:07

Patch will follow...

Comment #2

jover

Dutch

Leuven 🇧🇪

CreditAttribution: jover commented 15 January 2013 at 21:08

File	Size
references_dialog-various_js_bugfixes-1889582-2.patch	7.13 KB

Patched

Comment #3

jover

Dutch

Leuven 🇧🇪

CreditAttribution: jover commented 15 January 2013 at 21:12

Assigned:	jover	» Unassigned
Priority:	Normal	» Major
Status:	Active	» Needs review

Needs review...

Issue #1850808: jQuery 1.7.1 incompatability became obsolete with this patch...

Comment #4

rogical CreditAttribution: rogical commented 16 January 2013 at 02:22

Nice patch, If we can have a test through different versions of jquery, I'll commit this.

Comment #5

jaydub CreditAttribution: jaydub commented 18 January 2013 at 21:33

Using jQuery Update here to run with jQuery 1.7 and w/o this patch the add/edit links did not open a dialog. Applied patch and dialogs work again.

Comment #6

rogical CreditAttribution: rogical commented 19 January 2013 at 15:42

issue can be solved here together
#1800806: Wrong arguments for .click()

Comment #7

rwilson0429 CreditAttribution: rwilson0429 commented 11 February 2013 at 06:56

Patch in #2 works well for me.

Prior to patching, when using jQuery Update to run jQuery 1.7, could not select a reference from a View's Reference Dialog Display by clicking on it. Switching back to jQuery 1.5, clicking a reference from a View Reference Dialog display worked fine.

After applying the patch in #2, I reverted back to jQuery 1.7 and clicking on a reference from a View Reeference Dialog Display worked as expected (the clicked reference was placed on the input form). I also tested with jQuery 1.5 using this patch and it continued to function as expected.

Thanks for the patch.