When not creating a new revision is there any particular reason that the "Set Revision as default" option is still available? If a new revision is not being created then why would this option still be available? In my testing, unchecking the "Create new revision" option and then "Set Revision as default" results in the changes to fields not being saved! I recommend adding some logic to that field so it has no effect if "Create new revision" is disabled.

CommentFileSizeAuthor
#2 bean-n1891358.patch1.67 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Title: Expected results of "Set Revision as default" when not creating new revision » Data loss if both "Create new revision" and "Set Revision as default" options unchecked
Priority: Normal » Major

Clarified the title and bumped the priority as this is a dataloss bug.

DamienMcKenna’s picture

FileSize
1.67 KB

This patch overrides default_revision if the is_new_revision option was unchecked, thus avoiding the dataloss bug.

DamienMcKenna’s picture

Status: Active » Needs review
indytechcook’s picture

Issue tags: +Release blocker

Tagging with release blocker

indytechcook’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.