This is kind of a follow up issue to #1468582: Add mobile friendly meta tags to the html.tpl.php.
We included non-standard mobile friendly meta tags in html.tpl.php but we haven't included the hopefully soon-to-be-standard which is already supported by Windows 8.
It seems like we should include this for future compatibility, under the same switch that we include the current mobile friendly meta tags.
All the details on implementation you can grab from Trent Walton
Comment | File | Size | Author |
---|---|---|---|
#7 | Screenshot 2015-01-21 21.29.27.jpg | 89.2 KB | LewisNyman |
#3 | 1892078-mobile-viewport-3.patch | 497 bytes | Anonymous (not verified) |
Comments
Comment #1
LewisNyman CreditAttribution: LewisNyman commentedtagged
Comment #2
LewisNyman CreditAttribution: LewisNyman commentedComment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedHere's a patch. Hopefully system.module.css is the right place – anyone see a problem with this? Btw, only the -ms and unprefixed versions should be necessary, and they have to be separate selectors rather than on one line.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #5
LewisNyman CreditAttribution: LewisNyman commentedSorry I never reviewed this! This seems like a standard default that is easy for themes to override. Somehow it still applies.
Comment #6
webchickA couple questions about this:
- Seems like this needs testing on Windows non-8, as well as some other browsers?
- Wouldn't these CSS changes go into Classy theme these days?
Comment #7
LewisNyman CreditAttribution: LewisNyman commentedI've included some screenshots from an iPhone simulator, which doesn't support this property based on the MDN info page. It looks like Android supports this property now, so I guess we could get a screenshot of an Android 4.4 device
hmmm I'm not to sure in this situation. It's obvious that CSS that applies to a particular class only in Classy should go in Classy, but this doesn't depend on a class. It also mimics the same functionality we added in #1468582: Add mobile friendly meta tags to the html.tpl.php and that sits in system.module. Let's leave it in system for now.
Anyone with an Android 4.4 device out there?
Comment #8
idebr CreditAttribution: idebr commentedCaniuse data suggests support for this standard is still very meager at 13.4%: http://caniuse.com/#feat=css-deviceadaptation
The W3C specification is still a working draft: http://dev.w3.org/csswg/css-device-adapt/#the-atviewport-rule
And browser that supposedly support this declaration (most notably IE10) suffers from a buggy implementation: http://trentwalton.com/2013/01/16/windows-phone-8-viewport-fix/
I'm leaning towards 'Postponed' until either:
- Browser support has increased
- The existing implementations are less buggy
- The W3C spec becomes official
Comment #9
LewisNyman CreditAttribution: LewisNyman commentedOk, let's decide before we hit RC if this is a good idea or not.
Comment #10
catchThis could use manual testing on android it looks like, but it's definitely time to make that decision now. So moving back to active but untagging.