This is kind of a follow up issue to #1468582: Add mobile friendly meta tags to the html.tpl.php.

We included non-standard mobile friendly meta tags in html.tpl.php but we haven't included the hopefully soon-to-be-standard which is already supported by Windows 8.

It seems like we should include this for future compatibility, under the same switch that we include the current mobile friendly meta tags.

All the details on implementation you can grab from Trent Walton

CommentFileSizeAuthor
#7 Screenshot 2015-01-21 21.29.27.jpg89.2 KBLewisNyman
#3 1892078-mobile-viewport-3.patch497 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

Issue tags: +mobile

tagged

LewisNyman’s picture

Issue summary: View changes
Issue tags: +CSS, +frontend
Anonymous’s picture

Here's a patch. Hopefully system.module.css is the right place – anyone see a problem with this? Btw, only the -ms and unprefixed versions should be necessary, and they have to be separate selectors rather than on one line.

Anonymous’s picture

Status: Active » Needs review
LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community

Sorry I never reviewed this! This seems like a standard default that is easy for themes to override. Somehow it still applies.

webchick’s picture

Status: Reviewed & tested by the community » Needs review

A couple questions about this:

- Seems like this needs testing on Windows non-8, as well as some other browsers?
- Wouldn't these CSS changes go into Classy theme these days?

LewisNyman’s picture

Seems like this needs testing on Windows non-8, as well as some other browsers?

I've included some screenshots from an iPhone simulator, which doesn't support this property based on the MDN info page. It looks like Android supports this property now, so I guess we could get a screenshot of an Android 4.4 device

Wouldn't these CSS changes go into Classy theme these days?

hmmm I'm not to sure in this situation. It's obvious that CSS that applies to a particular class only in Classy should go in Classy, but this doesn't depend on a class. It also mimics the same functionality we added in #1468582: Add mobile friendly meta tags to the html.tpl.php and that sits in system.module. Let's leave it in system for now.

Anyone with an Android 4.4 device out there?

idebr’s picture

Caniuse data suggests support for this standard is still very meager at 13.4%: http://caniuse.com/#feat=css-deviceadaptation

The W3C specification is still a working draft: http://dev.w3.org/csswg/css-device-adapt/#the-atviewport-rule

And browser that supposedly support this declaration (most notably IE10) suffers from a buggy implementation: http://trentwalton.com/2013/01/16/windows-phone-8-viewport-fix/

I'm leaning towards 'Postponed' until either:
- Browser support has increased
- The existing implementations are less buggy
- The W3C spec becomes official

LewisNyman’s picture

Status: Needs review » Postponed
Issue tags: +revisit before release candidate

Ok, let's decide before we hit RC if this is a good idea or not.

catch’s picture

Status: Postponed » Active
Issue tags: -revisit before release candidate

This could use manual testing on android it looks like, but it's definitely time to make that decision now. So moving back to active but untagging.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.