EntityManager should use the CacheDecorator

Big, big +1.

However :

@@ -48,11 +41,10 @@ function entity_get_info($entity_type = NULL) {
  * Resets the cached information about entity types.
  */
 function entity_info_cache_clear() {
  (...)
   // Clear all languages.
-  cache()->deleteTags(array('entity_info' => TRUE));
+  drupal_container()->get('plugin.manager.entity')->clearCachedDefinitions();
 }

EntityManager::clearCachedDefinitions() will only clear the data for the current language, won't it ?
(aka #1722882-41: Plugin CacheDecorator caches globally, ignores request context, and does not specify tags for cache items)

2 days to next Drupal core point release.

Looks good.
I was a bit confused that the cache tags are declared as array('entity_info' => TRUE), while the issue in #3 does array('block'). I *think* both work, but easier way I think the method here seems to be more standard as cache tags were primarily introduced for the array('node' => array(1, 2, 3)) use-case.

@tim : Ah, right, skipped that. Too long since I've been able to crack my D8 open :-/
(+ sorry about status change, was not intentional)

Assuming it passes tests, this looks pretty sane to me.

RTBC

Bumping to major, since the drupal_static() in entity_get_info() actually causes a mismatch between actual discovery info and statically cached info at runtime, which took me some hours of debugging to figure out in #1901380: [Block]PluginManager repetitively triggers full-stack Annotation parsing on a plugin instance ID miss

The changes here seem to be identical with regard to the EntityManager, so let's make sure to get this in ASAP.

Only a few remarks:

(If anything I'm saying is not the case, then we need crystal clear comments that explain why the respective code is still needed.)

+++ b/core/includes/common.inc
@@ -6430,7 +6430,7 @@ function drupal_flush_all_caches() {
   // Clear all non-drupal_static() static caches.
-  // None currently; kept if any static caches need to be reset in the future.
+  drupal_container()->get('plugin.manager.entity')->clearCachedDefinitions();

This should not be necessary. All caches are flushed before that call already, and the entire kernel/container is rebuilt a few lines below.

+++ b/core/includes/entity.inc
@@ -48,11 +39,10 @@ function entity_get_info($entity_type = NULL) {
 function entity_info_cache_clear() {
-  drupal_static_reset('entity_get_info');
...
   // Clear all languages.
-  cache()->deleteTags(array('entity_info' => TRUE));
+  drupal_container()->get('plugin.manager.entity')->clearCachedDefinitions();

Likewise, this should simply vanish.

+++ b/core/modules/translation_entity/lib/Drupal/translation_entity/Tests/EntityTranslationSettingsTest.php
@@ -115,7 +115,7 @@ protected function assertSettings($entity_type, $bundle, $enabled, $edit) {
-    drupal_static_reset();
+    entity_info_cache_clear();

Tests simply call into $this->rebuildContainer(). This one might still need the static reset for the bundles/view-modes though.

Let's document that then.

Thanks, works for me! Agreed with RTBC. Time to get rid of that static! :)

Hopefully it comes back green.

That's very nice. Committed/pushed to 8.x.

this one filled with change record due to @depretaced function
needs review

still a task, right?