Here's a patch that combines several patches:
#1548964: new comments posted below the pager [patch attached]
#1883502: Incorrect status message if comment is not yet approved
#1881732: Theme status messages in drupal way instead of pure html concatenation
#1792734: Indentation fix for threaded comments
#1822510: jquery 1.6+ incompatibility: reply scrolls to top of screen
#1842166: Reply comment not working with AJAX (redirect to new page).
Also includes these fixes:
- Properly scroll to added comment event when status message is included
- Only scroll to added comment or form when it isn't visible (scrolls the least amount possible)
- Change the order of ajax_commands to delete the comment form, then add the comment (this is so that the scroll to comment works perfectly)
- force a reload of the comment when submitting. This allows for other modules to fully populate the comment object with extra fields
The patch can be applied directly to the 7.x.1.x-dev branch.
Comment | File | Size | Author |
---|---|---|---|
ajax_comments-big_fix.patch | 10.22 KB | ttkaminski | |
Comments
Comment #1
muschpusch CreditAttribution: muschpusch commentedSorry i'm just seeing this for the first time! Could you please re-roll against current dev? The patch doesn't apply anymore...
Comment #2
muschpusch CreditAttribution: muschpusch commentedthis patch is a nice refactoring of some stuff!
Comment #3
mihai7221 CreditAttribution: mihai7221 commentedYes indeed is very nice, but the patch fails against the current dev.
Comment #4
muschpusch CreditAttribution: muschpusch commentedComment #5
formatC'vt CreditAttribution: formatC'vt commentedTry latest dev