Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
966 bytes
larowlan’s picture

Component: system.module » documentation
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Yay spelling.

larowlan’s picture

Title: Update system_update_8004 documentation typo 'indeces' to 'indices' » Update system_update_8004 and taxonomy_update_8001 documentation typo 'indeces' to 'indices'
Status: Reviewed & tested by the community » Needs work

Same issue exists in taxonomy.install.
Can we catch them both here?

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
1.91 KB
991 bytes

I have provided a patch to update both taxonomy and system refs.

jhodgdon’s picture

Assigned: nick_schuch » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks! That looks like it catches all of this particular word misspelling. I'll get it committed once the test bot line turns green.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Needs work

There are actually two more misspellings of indices like this in 8.x. I committed the above patch, but could someone also patch:
core/modules/system/lib/Drupal/system/Tests/Form/CheckboxTest.php: // Only values that can be used for array indeces are supported for
core/includes/common.inc: * would. This means integer indeces are preserved just like string indeces are,

Thanks!

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
1.52 KB

I have attached a patch to handle the spelling mistakes in #6.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Assuming tests pass

nick_schuch’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
595 bytes
1.52 KB

Dang! Missed one. :)

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

From pre #6
grep -ir indeces core|sed 's/indeces/<strong>indeces<\/strong>/g'
core/modules/system/system.install: // According to the documentation of db_change_field(), indeces using the
core/modules/system/system.install: // field should be dropped first; if the contrib module created any indeces,
core/modules/system/lib/Drupal/system/Tests/Form/CheckboxTest.php: // Only values that can be used for array indeces are supported for
core/modules/taxonomy/taxonomy.install: // According to the documentation of db_change_field(), indeces using the
core/modules/taxonomy/taxonomy.install: // indeces, it is its responsibility to drop them in an update function
core/includes/common.inc: * would. This means integer indeces are preserved just like string indeces are,

I think that's all of them, assuming tests pass
Thanks Nick for saving face for me over #8 there :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1894382-8-interdiff.patch, failed testing.

larowlan’s picture

Status: Needs work » Reviewed & tested by the community

Patch passed (1894382-8-indeces-to-indices.patch)
Second file was an interdiff :) shouldn't have been tested.

jhodgdon’s picture

Assigned: Unassigned » jhodgdon

Thanks! I'll get that committed shortly.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Commetted ;) and pushed to 8.x. Thanks!

jhodgdon’s picture

Assigned: jhodgdon » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.