Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As per:
http://api.drupal.org/api/drupal/includes!database!database.inc/function...
'indeces' needs to be 'indices'.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1894382-8-indeces-to-indices.patch | 1.52 KB | nick_schuch |
#9 | 1894382-8-interdiff.patch | 595 bytes | nick_schuch |
#7 | 1894382-7-indeces-to-indices.patch | 1.52 KB | nick_schuch |
#4 | 1894382-interdiff.txt | 991 bytes | nick_schuch |
#4 | 1894382-4-indeces-to-indices.patch | 1.91 KB | nick_schuch |
Comments
Comment #1
nick_schuch CreditAttribution: nick_schuch commentedComment #2
larowlanYay spelling.
Comment #3
larowlanSame issue exists in taxonomy.install.
Can we catch them both here?
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedI have provided a patch to update both taxonomy and system refs.
Comment #5
jhodgdonThanks! That looks like it catches all of this particular word misspelling. I'll get it committed once the test bot line turns green.
Comment #6
jhodgdonThere are actually two more misspellings of indices like this in 8.x. I committed the above patch, but could someone also patch:
core/modules/system/lib/Drupal/system/Tests/Form/CheckboxTest.php: // Only values that can be used for array indeces are supported for
core/includes/common.inc: * would. This means integer indeces are preserved just like string indeces are,
Thanks!
Comment #7
nick_schuch CreditAttribution: nick_schuch commentedI have attached a patch to handle the spelling mistakes in #6.
Comment #8
larowlanAssuming tests pass
Comment #9
nick_schuch CreditAttribution: nick_schuch commentedDang! Missed one. :)
Comment #10
larowlanFrom pre #6
grep -ir indeces core|sed 's/indeces/<strong>indeces<\/strong>/g'
core/modules/system/system.install: // According to the documentation of db_change_field(), indeces using the
core/modules/system/system.install: // field should be dropped first; if the contrib module created any indeces,
core/modules/system/lib/Drupal/system/Tests/Form/CheckboxTest.php: // Only values that can be used for array indeces are supported for
core/modules/taxonomy/taxonomy.install: // According to the documentation of db_change_field(), indeces using the
core/modules/taxonomy/taxonomy.install: // indeces, it is its responsibility to drop them in an update function
core/includes/common.inc: * would. This means integer indeces are preserved just like string indeces are,
I think that's all of them, assuming tests pass
Thanks Nick for saving face for me over #8 there :)
Comment #12
larowlanPatch passed (1894382-8-indeces-to-indices.patch)
Second file was an interdiff :) shouldn't have been tested.
Comment #13
jhodgdonThanks! I'll get that committed shortly.
Comment #14
webchickCommetted ;) and pushed to 8.x. Thanks!
Comment #15
jhodgdon