Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Allow chapter seeking based on urls as describe in http://www.longtailvideo.com/support/jw-player/jw-player-for-flash-v5/17... chapter "Alternative seeking use: permalinks".
Comment | File | Size | Author |
---|---|---|---|
#14 | jw_player-fix_js_seek-1894656-14.patch | 4.07 KB | ron_s |
#7 | jw_player-1894656-7.patch | 897 bytes | corvus_ch |
#5 | 1894656-5.patch | 4.21 KB | corvus_ch |
#4 | 1894656-4.patch | 3.32 KB | corvus_ch |
#1 | 1894656-1.patch | 3.06 KB | corvus_ch |
Comments
Comment #1
corvus_ch CreditAttribution: corvus_ch commentedComment #2
corvus_ch CreditAttribution: corvus_ch commentedComment #3
Berdir:)
File is missing...
Comment #4
corvus_ch CreditAttribution: corvus_ch commentedRemoved debug and included the missing file.
Comment #5
corvus_ch CreditAttribution: corvus_ch commentedFor my current use case I needed to extract the player id for usage in another field.
This patch contains the changes that allows me to do that.
Comment #6
BerdirLooks good, commited and pushed.
Comment #7
corvus_ch CreditAttribution: corvus_ch commentedI would like to reopen this for a follow up.
Today I realized that I need to be able to trigger seeking without knowing the player id.
The attached patch allows to do exactly that.
Comment #8
Hopiu CreditAttribution: Hopiu commentedDoes the player_id really have to be generated with the file id? What about a player having a playlist with multiple files?
See Issue: #1215108: Create a playlist field formatter (I rewrote that patch already to work with the current dev snapshot, but it get's dirty...)
Comment #9
corvus_ch CreditAttribution: corvus_ch commentedThat is really a problem.
The original intention was to get a id that is static and allows us to make use for linking. The module i am developing that had the need for this does not do so anymore. That is another problem.
The question then is how to proceed from here on?
Personally I would opt for option two. So my question goes to Hopiu: what can we use to build a static id that does not interfere with what you are trying to achieve?
Comment #10
BerdirComment #11
Hopiu CreditAttribution: Hopiu commentedIn my opinion we should at first create another field type "playlist" and solve those structural problems before getting more features into the module. According to your problem a static id could be part of this playlist type.
A playlist could look the following:
The first "level" isn't actually needed, but it provides a static id. Not all the fields have to be accessible for the user, or maybe there could be something like an advanced input form.
Maybe someone more experienced could give a hint if this can be done with "Fields" or on a better way to create such a strucutre...
Comment #13
corvus_ch CreditAttribution: corvus_ch commentedComment #14
ron_s CreditAttribution: ron_s commentedThe included patch connects to our Refactor theming work, and incorporates what has been done in previous patches on this thread.
There are three major components to what we have done:
1) Modify
jw_player.seek.js
to support JW Player 7.2) Ensure
jw_player.seek.js
is loaded afterjw_player.drupal.js
(new file with Refactor theming), otherwise it won't work.3) Include a new option for seek that is available as a preset checkbox, so developers can choose to enable seek for only one particular field on a page (such as the primary content video). This is based off of the concept shown here: https://developer.jwplayer.com/jw-player/demos/basic/linking-to-time-off...
Note 1: #3 is not included in this patch, since we're trying to keep this focused on just the existing seek functionality. However we have a patch ready to go once some of the other current patches have been committed.
Note 2: As discussed in the refactor theming thread, this is another issue that relies on the need for a (fairly) unique html_id.