Illegal Offset Error when the field is set to allow "Unlimited" values [#1894916]

When I have the taxonomy reference field of type "Simple Hierarchical Select" set to allow unlimited values I get the following errors when saving a node.

Warning: Illegal offset type in shs_term_get_children() (line 457 of /Users/daniel/projects/drupal/novita/sites/all/modules/shs/shs.module).
Warning: Illegal offset type in shs_term_get_children() (line 464 of /Users/daniel/projects/drupal/novita/sites/all/modules/shs/shs.module).
Warning: Illegal offset type in isset or empty in taxonomy_get_tree() (line 1156 of /Users/daniel/projects/drupal/novita/modules/taxonomy/taxonomy.module).
Warning: Illegal offset type in shs_term_get_children() (line 496 of /Users/daniel/projects/drupal/novita/sites/all/modules/shs/shs.module).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /Users/daniel/projects/drupal/novita/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /Users/daniel/projects/drupal/novita/includes/entity.inc).
Warning: Illegal offset type in taxonomy_field_validate() (line 1519 of /Users/daniel/projects/drupal/novita/modules/taxonomy/taxonomy.module).
Notice: Trying to get property of non-object in taxonomy_field_validate() (line 1519 of /Users/daniel/projects/drupal/novita/modules/taxonomy/taxonomy.module).
Car Models: illegal value.

Comments

Comment #1

danielboggs CreditAttribution: danielboggs commented 21 January 2013 at 21:42

I also just tested this on a fresh Drupal 7.19 install with no other modules other than core enabled to verify it wasn't something conflicting in the project I am working on. I get the same problem there as well. If I set the field to allow unlimited or multiple values I get the above errors when saving the node.

Comment #2

stBorchert

he/him

German

CreditAttribution: stBorchert commented 22 January 2013 at 14:57

Version:	7.x-1.3	» 7.x-1.x-dev
Status:	Active	» Needs review

Uh, this was really bad. I had to change the structure in which the data is saved.
Anyway, the error should now be gone. Please test using the latest dev-release ("7.x-1.2+3-dev", available at http://drupal.org/node/1892316).

Comment #3

danielboggs CreditAttribution: danielboggs commented 22 January 2013 at 17:07

The Tagging works fine now. The only issue I'm seeing is when the field is set to allow "Ulimited" values if you specify the first term and then select "Add another item" the front-end value for the first tag reference field gets reset to "none". Though when I save the node and edit it; it appears to have retained the taggings, they are just not visible during the initial process of adding them when adding more than one item.

Comment #4

danielboggs CreditAttribution: danielboggs commented 22 January 2013 at 17:21

It appears that javascript is re-rendering the entire field based on what is already stored for the node inside the database instead of just appending a row to the form and thus resetting the values of the above selection.