Inconsistent check for translatable title in _i18n_menu_link_localizable_properties() and _i18n_menu_link_localize()

I have the exact same problem and upgrading to the latest dev snapshot also didn't fix it

I think the essential difference to check for that's missing here is if the link is customized (manually created in the UI).
Local tests look good so far.

I don't think the patch fixes the problem.

The issue is not that we cannot add a translation for the link, but that the menu link is being translated -tried to- in _i18n_menu_link_localize() when it shouldn't be (because it is localized with 't')

So I think to fix this we should add the right check into _i18n_menu_link_localize(), which is something like: if title callback == 't' and 'title' == router title (link_title), then do not localize.
Optionally if that's too hard, we could just check whether the link title has already changed and if so, skip translation there.

About these conditions, see menu.inc _menu_item_localize()

Related #2007752: Menu translation when menu has title_callback different then "t"

Hi everybody,

I can confirm that I have similar issue and this patch resolves it.

Issue summary: manually created menu items that have the same title as menu route cannot be translated via the UI and is not being translated by the Drupal core (probably because they have customized value set to 1).

Steps to reproduce:

1. Create a menu item with user/login path entitled Log in
2. When you want add translation to it you'll get This object has no strings available for translation.
3. i18n_menu will not add this link to strings
4. Translate Log in string (built-in interface text group!)
5. Switch to another language and you should see that menu item in question is not translated

Couple more thoughts on this.

1. Why does i18n_menu skip the contributed modules provided links ? Is there a reason for that ?
2. Why does i18n_menu skip the links which have the same title as a corresponding menu router? I believe core is responsible for page title translation (with t()), but not the menu links (because we should distinguish between these 2 terms)

Thanks!

Taking into account #3 check attached patch.

Actually, why do not allow each item translation, despite the fact that title for menu router (page title) is the same as menu title. This creates non-consistent behavior and very hard to explain for a site managers. It's very confusing.

The same condition needs to applied for the description field as well.

Updated the patch to include the description field as well.

The attached path is a re-roll of #9 for latest 7.x-1.x-dev.

Patch passed test, it's a reroll of another patch which was a enhancement of a patch already confirmed as working by Taran2L in #5. It fixes the inconsistency and the observed bad behavior it causes.

Patch in comment #10 fixed the problem for me

Just run into this issue, and patch from #10 fixed the issue for me but need to be re-rolled against dev.

Here is the updated version

I confirm same issue with a menu link called "Register". Patch from #15 fixes it.

This has been RTBC for a long while now, time to get this in?

Committed, thanks everybody.