Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I had some trouble getting my site to recognize the jquery.timeago.js library. This line ultimately helped me figure it out:
If the Libraries module (2.x) is installed, Timeago will use it to manage the library.
However, I was still just guessing that it should live at sites/all/libraries/timeago/jquery.timeago.js.
I would recommend adding more explicit instructions about using the Libraries module, even just listing the directory structure pasted above. Sounds newb-ish, but will definitely avoid confusion down the line.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | timeago-library-location-1897816-3.patch | 1.12 KB | IceCreamYou |
Comments
Comment #1
IceCreamYou CreditAttribution: IceCreamYou commentedI don't understand the problem you were having. Where were you putting the file where it didn't work, and where did you ultimately put it where it did work?
Timeago can use the Libraries module to manage the jquery.timeago.js library if it is installed. In that case, it does not specify where the JS file has to go, it just asks the Libraries module to figure out where it is and load it. Whether you have the Libraries module installed or not, you can always put the JS file in the module directory.
Comment #2
aboutblank CreditAttribution: aboutblank commentedSo basically I had the library in
sites/all/modules/timeago/jquery.timeago.jsand it wasn't loading on the page.I moved it to
sites/default/files/timeago/jquery.timeago.js(which I guessed based on other Libraries I've installed) and it did load on the page.It could have been a cache issue or just my ignorance of Libraries, so I'll see if I can replicate it.
Comment #3
IceCreamYou CreditAttribution: IceCreamYou commentedOh, that could be the case actually. It probably shouldn't be the case (obviously that's not the way I thought it worked) but looking at the code it looks like that's what happens. The attached patch should fix it...
Comment #4
Zatox CreditAttribution: Zatox commentedNice patch but even if it had been applied to the version i'm using (2.2) I still would have had a little problem. I put a translation file in the module's directory as explained in the README (line 102) but since I'm using the Drupal Commons distribution, the timeago library was in the libraries folder so the module was looking for the localization file in the libraries/timeago folder as reflected by line 369 of timeago.module:
To avoid misguiding site builders I think the better thing to do would be to change the README line to "This translation file should be placed in the same folder as the time ago library (ie. jquery.timeago.js)"
The () part is so users don't mistake the library with the module's helper JS (timeago.js). Just in case
Comment #5
IceCreamYou CreditAttribution: IceCreamYou commentedCommitted fix to dev. Thanks.
Comment #8
jcnventura CreditAttribution: jcnventura at Wunder commentedThis fix seems to have broken libraries support, instead of fixing it. See #2804993: looking for jquery.timeago.js in module folder.