Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Title says it all. While working on something else, I discovered that it's even passing in a non-existing variable…
Comment | File | Size | Author |
---|---|---|---|
#1 | hook_editor_js_settings_alter_tests-1898844-1.patch | 3.22 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersComment #3
Gábor Hojtsy#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.
Comment #4
Gábor HojtsyThe test looks good, it properly isolates the tested change so it does not happen for other cases. If it comes back green it should be committed :) Marking RTBC for that. (Retesting since it was developed 2 weeks ago).
Comment #6
Wim Leers#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.
Comment #8
Gábor HojtsyOpenIDAuthmapUpgradePathTest not related.
Comment #9
Gábor Hojtsy#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.
Comment #11
Wim Leers#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.
Comment #12
Wim LeersBack to RTBC per #4.
Comment #13
webchickOops. :) Thanks for the additional test coverage.
Committed and pushed to 8.x. Thanks!