Title says it all. While working on something else, I discovered that it's even passing in a non-existing variable…

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Status: Active » Needs review
FileSize
3.22 KB
Wim Leers’s picture

Issue tags: +wysiwyg, +Spark, +CKEditor in core
Gábor Hojtsy’s picture

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

The test looks good, it properly isolates the tested change so it does not happen for other cases. If it comes back green it should be committed :) Marking RTBC for that. (Retesting since it was developed 2 weeks ago).

Status: Reviewed & tested by the community » Needs work
Issue tags: -wysiwyg, -Spark, -CKEditor in core

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

Wim Leers’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +wysiwyg, +Spark, +CKEditor in core

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

Gábor Hojtsy’s picture

OpenIDAuthmapUpgradePathTest not related.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
Issue tags: -wysiwyg, -Spark, -CKEditor in core

Status: Needs review » Needs work

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

Wim Leers’s picture

Status: Needs work » Needs review
Issue tags: +wysiwyg, +Spark, +CKEditor in core
Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC per #4.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Oops. :) Thanks for the additional test coverage.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.