When using devel_generate, I get the following error when generating nodes with attached images stored in Storage API containers:

Missing argument 2 for DrupalStorageStreamWrapper::url_stat()

I'll attach a quick and dirty patch to tide me over. I think the proper fix should probably happen in devel_generate instead.

CommentFileSizeAuthor
#10 storage-api-1899016.patch672 bytesjonhattan
#7 storage_api-n1899016-7.patch516 bytesDamienMcKenna
#2 storage_api-provide_missing_param-1899016-2.patch483 bytes30equals
#1 missing-argument-for-url-stat-1899016-1.patch515 byteswulff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wulff’s picture

wulff CreditAttribution: wulff commented
FileSize
missing-argument-for-url-stat-1899016-1.patch515 bytes

...and the patch.

30equals’s picture

30equals CreditAttribution: 30equals commented
FileSize
storage_api-provide_missing_param-1899016-2.patch483 bytes

I saw the same problem, but for what it's worth, i'd fix it where the function get's called, instead of giving a default value - just to maintain consistency with the main Class ?

wulff’s picture

wulff CreditAttribution: wulff commented

Hm. I still think it would make sense to fix it in Storage API according to the definition of url_stat on http://www.php.net/manual/en/class.streamwrapper.php.

Perignon’s picture

Perignon CreditAttribution: Perignon commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

This is an old issue. Is it still valid?

Silicon.Valet’s picture

Silicon.Valet CreditAttribution: Silicon.Valet commented

Yes. http://cgit.drupalcode.org/storage_api/tree/core_bridge/storage_core_bri...

Patch works as described.

Perignon’s picture

Perignon CreditAttribution: Perignon commented
Assigned: Unassigned » Perignon
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
storage_api-n1899016-7.patch516 bytes

There's no point in keeping the argument because it isn't actually used in the method.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

The method should at least test STREAM_URL_STAT_QUIET flag and behave in consecuence (do not raise an exception). It is already implemented in the storage_api_stream_wrapper module - http://cgit.drupalcode.org/storage_api_stream_wrapper/tree/StorageApiStr...

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

@jonhattan: Could you please update the patch with at least some comments or pseudocode on what you should it should be? I've not looked at Storage API before so have absolutely no clue :)

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
FileSize
storage-api-1899016.patch672 bytes

Committing attached patch.

Just realized I'm a maintainer of this module! Thanks!? @Perignon :D

Perignon’s picture

Perignon CreditAttribution: Perignon commented

;-) I appreciate the help a lot!

  • jonhattan committed 6fe61a9 on 7.x-1.x 
    Issue #1899016: Missing argument 2 for DrupalStorageStreamWrapper::...
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs review » Fixed
Perignon’s picture

Perignon CreditAttribution: Perignon commented

I will try and keep the Github and Bitbucket repo's up to date.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Fixed » Needs work

But that's a workaround rather than an actual fix for the simple problem that a required variable in the method isn't actually used.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

We loose the focus here. class DrupalStorageStreamWrapper implements DrupalStreamWrapperInterface, DrupalStreamWrapperInterface extends StreamWrapperInterface. StreamWrapperInterface is a Drupal class that provides an interface for the PHP prototype of a stream wrapper class - http://www.php.net/manual/en/class.streamwrapper.php

So we want to follow the interfaces signature: public function url_stat($uri, $flags);, and thus we need to pass a value for flags in all of our calls.

  • jonhattan committed 69250df on 7.x-1.x 
    Follow-up to issue #1899016: Missing argument 2 for...
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.